kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: pbonzini@redhat.com, andre.przywara@arm.com,
	peter.maydell@linaro.org, alex.bennee@linaro.org,
	marc.zyngier@arm.com, eric.auger@redhat.com,
	christoffer.dall@linaro.org, Andrew Jones <drjones@redhat.com>
Subject: [kvm-unit-tests PATCH v4 02/11] arm64: fix get_"sysreg32" and make MPIDR 64bit
Date: Tue,  8 Nov 2016 21:21:30 +0100	[thread overview]
Message-ID: <1478636499-14339-3-git-send-email-drjones@redhat.com> (raw)
In-Reply-To: <1478636499-14339-1-git-send-email-drjones@redhat.com>

mrs is always 64bit, so we should always use a 64bit register.
Sometimes we'll only want to return the lower 32, but not for
MPIDR, as that does define fields in the upper 32.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 lib/arm64/asm/processor.h | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/lib/arm64/asm/processor.h b/lib/arm64/asm/processor.h
index 84d5c7ce752b..9a208ff729b7 100644
--- a/lib/arm64/asm/processor.h
+++ b/lib/arm64/asm/processor.h
@@ -66,14 +66,17 @@ static inline unsigned long current_level(void)
 	return el & 0xc;
 }
 
-#define DEFINE_GET_SYSREG32(reg)				\
-static inline unsigned int get_##reg(void)			\
+#define DEFINE_GET_SYSREG(reg, type)				\
+static inline type get_##reg(void)				\
 {								\
-	unsigned int reg;					\
-	asm volatile("mrs %0, " #reg "_el1" : "=r" (reg));	\
-	return reg;						\
+	unsigned long r;					\
+	asm volatile("mrs %0, " #reg "_el1" : "=r" (r));	\
+	return (type)r;						\
 }
-DEFINE_GET_SYSREG32(mpidr)
+#define DEFINE_GET_SYSREG32(reg) DEFINE_GET_SYSREG(reg, unsigned int)
+#define DEFINE_GET_SYSREG64(reg) DEFINE_GET_SYSREG(reg, unsigned long)
+
+DEFINE_GET_SYSREG64(mpidr)
 
 /* Only support Aff0 for now, gicv2 only */
 #define mpidr_to_cpu(mpidr) ((int)((mpidr) & 0xff))
-- 
2.7.4


  parent reply	other threads:[~2016-11-08 20:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 20:21 [kvm-unit-tests PATCH v4 00/11] arm/arm64: add gic framework Andrew Jones
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 01/11] lib: xstr: allow multiple args Andrew Jones
2016-11-08 20:21 ` Andrew Jones [this message]
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 03/11] arm/arm64: smp: support more than 8 cpus Andrew Jones
2016-11-09 11:12   ` Andre Przywara
2016-11-09 11:57     ` Andrew Jones
2016-11-09 12:01       ` Andre Przywara
2016-11-09 12:13         ` [Qemu-devel] " Andrew Jones
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 04/11] arm/arm64: add some delay routines Andrew Jones
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 05/11] arm/arm64: irq enable/disable Andrew Jones
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 06/11] arm/arm64: add initial gicv2 support Andrew Jones
2016-11-09 11:53   ` Andre Przywara
2016-11-09 12:06     ` [Qemu-devel] " Andrew Jones
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 07/11] arm/arm64: gicv2: add an IPI test Andrew Jones
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 08/11] libcflat: add IS_ALIGNED() macro, and page sizes Andrew Jones
2016-11-09 14:59   ` Andre Przywara
2016-11-09 15:07   ` Peter Xu
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 09/11] arm/arm64: add initial gicv3 support Andrew Jones
2016-11-09 12:35   ` Andre Przywara
2016-11-09 13:08     ` [Qemu-devel] " Andrew Jones
2016-11-09 14:43       ` Andre Przywara
2016-11-09 15:23         ` Andrew Jones
2016-11-09 16:59           ` André Przywara
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 10/11] arm/arm64: gicv3: add an IPI test Andrew Jones
2016-11-09  8:33   ` Andrew Jones
2016-11-08 20:21 ` [kvm-unit-tests PATCH v4 11/11] arm/arm64: gic: don't just use zero Andrew Jones
  -- strict thread matches above, loose matches on Subject: below --
2016-11-10 16:07 [kvm-unit-tests PATCH v4 00/11] arm/arm64: add gic framework Andrew Jones
2016-11-10 16:07 ` [kvm-unit-tests PATCH v4 02/11] arm64: fix get_"sysreg32" and make MPIDR 64bit Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478636499-14339-3-git-send-email-drjones@redhat.com \
    --to=drjones@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=andre.przywara@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).