From: Jim Mattson <jmattson@google.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>, kvm@vger.kernel.org
Cc: Jim Mattson <jmattson@google.com>
Subject: [PATCH v2] kvm: nVMX: CPUID.01H:EDX.APIC[bit 9] should mirror IA32_APIC_BASE[11]
Date: Wed, 9 Nov 2016 09:04:36 -0800 [thread overview]
Message-ID: <1478711076-1426-1-git-send-email-jmattson@google.com> (raw)
In-Reply-To: <CALMp9eStHi7-Qhw9uXanBjHpLW0Ce_1HcZdhnDK88hD+p6mWxg@mail.gmail.com>
>From the Intel SDM, volume 3, section 10.4.3, "Enabling or Disabling the
Local APIC,"
When IA32_APIC_BASE[11] is 0, the processor is functionally equivalent
to an IA-32 processor without an on-chip APIC. The CPUID feature flag
for the APIC (see Section 10.4.2, "Presence of the Local APIC") is
also set to 0.
Signed-off-by: Jim Mattson <jmattson@google.com>
---
arch/x86/kvm/cpuid.c | 4 ++++
arch/x86/kvm/lapic.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index afa7bbb..84b62ee 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -81,6 +81,10 @@ int kvm_update_cpuid(struct kvm_vcpu *vcpu)
best->ecx |= F(OSXSAVE);
}
+ best->edx &= ~F(APIC);
+ if (vcpu->arch.apic_base & MSR_IA32_APICBASE_ENABLE)
+ best->edx |= F(APIC);
+
if (apic) {
if (best->ecx & F(TSC_DEADLINE_TIMER))
apic->lapic_timer.timer_mode_mask = 3 << 17;
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 23b99f3..eda4284e 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -1758,6 +1758,7 @@ void kvm_lapic_set_base(struct kvm_vcpu *vcpu, u64 value)
/* update jump label if enable bit changes */
if ((old_value ^ value) & MSR_IA32_APICBASE_ENABLE) {
+ kvm_update_cpuid(vcpu);
if (value & MSR_IA32_APICBASE_ENABLE) {
kvm_apic_set_xapic_id(apic, vcpu->vcpu_id);
static_key_slow_dec_deferred(&apic_hw_disabled);
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-11-09 17:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 22:00 [PATCH] kvm: nVMX: CPUID.01H:EDX.APIC[bit 9] should mirror IA32_APIC_BASE[11] Jim Mattson
2016-11-08 16:33 ` Radim Krčmář
2016-11-09 16:53 ` Jim Mattson
2016-11-09 17:04 ` Jim Mattson [this message]
2016-11-09 17:14 ` [PATCH v2] " Paolo Bonzini
2016-11-09 17:28 ` Jim Mattson
2016-11-09 17:37 ` Paolo Bonzini
2016-11-09 17:41 ` Jim Mattson
2016-11-09 17:43 ` Paolo Bonzini
[not found] ` <CALMp9eRek+NYZJYfT5TwCR+w=1hdS6e-O+Hm_RzF5MCykOHtWA@mail.gmail.com>
2016-11-10 17:18 ` Paolo Bonzini
2016-11-14 18:14 ` [kvm-unit-tests PATCH] x86: Test disabled local APIC Jim Mattson
2016-11-22 13:55 ` Radim Krčmář
2016-11-09 17:50 ` [PATCH v3] kvm: nVMX: CPUID.01H:EDX.APIC[bit 9] should mirror IA32_APIC_BASE[11] Jim Mattson
2016-11-22 13:53 ` Radim Krčmář
2016-11-09 17:15 ` [PATCH v2] " Igor Mammedov
2016-11-09 17:37 ` Eduardo Habkost
2016-11-09 17:42 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478711076-1426-1-git-send-email-jmattson@google.com \
--to=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).