kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	marc.zyngier-5wv7dgnIgG8@public.gmane.org,
	robin.murphy-5wv7dgnIgG8@public.gmane.org,
	alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
	jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	punit.agrawal-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: [RFC v3 10/10] vfio/type1: Get MSI cookie
Date: Tue, 15 Nov 2016 13:09:23 +0000	[thread overview]
Message-ID: <1479215363-2898-11-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1479215363-2898-1-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

When attaching a group to the container, handle the group's
reserved regions and particularly the IOMMU_RESV_MSI region
which requires an IOVA allocator to be initialized through
the iommu_get_msi_cookie API. This will allow the MSI IOVAs
to be transparently allocated on MSI controller's compose().

Signed-off-by: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 drivers/vfio/vfio_iommu_type1.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index 2ba1942..701d8a8 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -36,6 +36,7 @@
 #include <linux/uaccess.h>
 #include <linux/vfio.h>
 #include <linux/workqueue.h>
+#include <linux/dma-iommu.h>
 
 #define DRIVER_VERSION  "0.2"
 #define DRIVER_AUTHOR   "Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>"
@@ -734,6 +735,27 @@ static void vfio_test_domain_fgsp(struct vfio_domain *domain)
 	__free_pages(pages, order);
 }
 
+static int vfio_iommu_handle_resv_regions(struct iommu_domain *domain,
+					  struct iommu_group *group)
+{
+	struct list_head group_resv_regions;
+	struct iommu_resv_region *region, *next;
+	int ret = 0;
+
+	INIT_LIST_HEAD(&group_resv_regions);
+	iommu_get_group_resv_regions(group, &group_resv_regions);
+	list_for_each_entry(region, &group_resv_regions, list) {
+		if (region->prot & IOMMU_RESV_MSI) {
+			ret = iommu_get_msi_cookie(domain, region->start);
+			if (ret)
+				break;
+		}
+	}
+	list_for_each_entry_safe(region, next, &group_resv_regions, list)
+		kfree(region);
+	return ret;
+}
+
 static int vfio_iommu_type1_attach_group(void *iommu_data,
 					 struct iommu_group *iommu_group)
 {
@@ -834,6 +856,10 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
 	if (ret)
 		goto out_detach;
 
+	ret = vfio_iommu_handle_resv_regions(domain->domain, iommu_group);
+	if (ret)
+		goto out_detach;
+
 	list_add(&domain->next, &iommu->domain_list);
 
 	mutex_unlock(&iommu->lock);
-- 
1.9.1

  parent reply	other threads:[~2016-11-15 13:09 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 13:09 [RFC v3 00/10] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Eric Auger
2016-11-15 13:09 ` [RFC v3 04/10] iommu: iommu_alloc_resv_region Eric Auger
     [not found]   ` <1479215363-2898-5-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-29 16:11     ` Joerg Roedel
     [not found]       ` <20161129161128.GI2078-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-11-30  9:41         ` Auger Eric
2016-12-06 17:30     ` Robin Murphy
     [not found] ` <1479215363-2898-1-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-15 13:09   ` [RFC v3 01/10] iommu/dma: Allow MSI-only cookies Eric Auger
2016-11-15 13:09   ` [RFC v3 02/10] iommu: Rename iommu_dm_regions into iommu_resv_regions Eric Auger
     [not found]     ` <1479215363-2898-3-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-06 17:30       ` Robin Murphy
2016-11-15 13:09   ` [RFC v3 03/10] iommu: Add new reserved IOMMU attributes Eric Auger
     [not found]     ` <1479215363-2898-4-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-06 17:28       ` Robin Murphy
2016-11-15 13:09   ` [RFC v3 05/10] iommu: Do not map reserved regions Eric Auger
     [not found]     ` <1479215363-2898-6-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-06 17:36       ` Robin Murphy
     [not found]         ` <fff44f65-d9a6-1e35-97cd-997b92d2fce3-5wv7dgnIgG8@public.gmane.org>
2016-12-07 15:15           ` Auger Eric
2016-11-15 13:09   ` [RFC v3 06/10] iommu: iommu_get_group_resv_regions Eric Auger
     [not found]     ` <1479215363-2898-7-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-06 18:13       ` Robin Murphy
     [not found]         ` <8eb9662b-d677-546c-feb8-32fe5bd624f2-5wv7dgnIgG8@public.gmane.org>
2016-12-07 15:13           ` Auger Eric
2016-11-15 13:09   ` [RFC v3 07/10] iommu: Implement reserved_regions iommu-group sysfs file Eric Auger
2016-11-15 13:09   ` [RFC v3 08/10] iommu/vt-d: Implement reserved region get/put callbacks Eric Auger
2016-11-15 13:09   ` [RFC v3 09/10] iommu/arm-smmu: " Eric Auger
     [not found]     ` <1479215363-2898-10-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-06 18:55       ` Robin Murphy
     [not found]         ` <02c0ce15-fa67-e65f-3a4e-f543cc9fd3b8-5wv7dgnIgG8@public.gmane.org>
2016-12-07 15:02           ` Auger Eric
     [not found]             ` <c11755b8-4fb3-3f2f-d0b2-e688a5f8a6b6-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-07 18:24               ` Robin Murphy
     [not found]                 ` <5de00158-c82d-6b47-cf64-d4ba0183868d-5wv7dgnIgG8@public.gmane.org>
2016-12-08  7:57                   ` Auger Eric
2016-11-15 13:09   ` Eric Auger [this message]
2016-11-18  5:34   ` [RFC v3 00/10] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Bharat Bhushan
2016-11-18  8:33     ` Auger Eric
2016-11-30  9:49   ` Auger Eric
2016-11-30 10:04     ` Ganapatrao Kulkarni
     [not found]       ` <CAFpQJXWp5BfsxU5nkWm7hrq5wp6=b-6iYVHjBQYhmkWN_kSSzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-30 10:14         ` Auger Eric
2016-11-30 10:52           ` Ganapatrao Kulkarni
     [not found]             ` <CAFpQJXVqStQwRkm9F=e+8UFxWsddcwgB=AyfnZXSSaOw3eyBUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-30 13:57               ` Robin Murphy
     [not found]           ` <3d0ddb50-6e63-3fe2-55c0-ce49579905c9-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-30 14:14             ` Alex Williamson
     [not found]     ` <6c9012fd-070b-6218-48e7-69b37f2559dd-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-30 10:37       ` Will Deacon
     [not found]         ` <20161130103713.GB2724-5wv7dgnIgG8@public.gmane.org>
2016-11-30 14:08           ` Auger Eric
     [not found]             ` <1899e46c-7b06-01d6-6cff-eb0985a4f11d-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-30 14:41               ` Robin Murphy
2016-12-07 18:52             ` Shanker Donthineni
     [not found]               ` <165d4f72-ef74-2db8-166a-1f90208315c8-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-12-08  7:34                 ` Auger Eric
2016-12-08  3:56   ` Bharat Bhushan
2016-12-08  9:36   ` Auger Eric
     [not found]     ` <c5d4efa7-699d-4aa3-44cc-4ce03d0ce185-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-08 13:14       ` Robin Murphy
     [not found]         ` <cd16fc5c-8649-0bfa-d67d-8f257aa38bd6-5wv7dgnIgG8@public.gmane.org>
2016-12-08 13:36           ` Auger Eric
     [not found]             ` <48e7d75a-8499-7f41-42d0-08fe081c192b-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-08 15:46               ` Robin Murphy
2016-12-08 17:01           ` Alex Williamson
2016-12-08 18:42             ` Robin Murphy
2016-12-11  2:05       ` Don Dutile
     [not found]         ` <584CB481.3040902-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-12-12  8:12           ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479215363-2898-11-git-send-email-eric.auger@redhat.com \
    --to=eric.auger-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
    --cc=pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=punit.agrawal-5wv7dgnIgG8@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).