kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, pbonzini@redhat.com, lvivier@redhat.com,
	thuth@redhat.com
Subject: [kvm-unit-tests PATCH] [RFC] run: add -nodefaults
Date: Tue, 15 Nov 2016 18:47:27 +0100	[thread overview]
Message-ID: <1479232047-22195-1-git-send-email-drjones@redhat.com> (raw)

Adding pci-test to arm allowed us to see that a virtio-net-pci
device was getting added to our machine by default. Unit tests
should configure the most minimal machines they can, only adding
devices necessary for the tests. Let's add -nodefaults to all
the run scripts.

I tested all arches (powerpc and arm on tcg). There were no
unexpected changes.

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 arm/run     | 2 +-
 powerpc/run | 2 +-
 x86/run     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arm/run b/arm/run
index 1ee6231599d6..f1b04af614dc 100755
--- a/arm/run
+++ b/arm/run
@@ -73,7 +73,7 @@ if $qemu $M -device '?' 2>&1 | grep pci-testdev > /dev/null; then
 fi
 
 M+=",accel=$ACCEL"
-command="$qemu $M -cpu $processor $chr_testdev $pci_testdev"
+command="$qemu -nodefaults $M -cpu $processor $chr_testdev $pci_testdev"
 command+=" -display none -serial stdio -kernel"
 command="$(timeout_cmd) $command"
 echo $command "$@"
diff --git a/powerpc/run b/powerpc/run
index 14988a75b1e2..afdd487bfc35 100755
--- a/powerpc/run
+++ b/powerpc/run
@@ -43,7 +43,7 @@ fi
 
 M='-machine pseries'
 M+=",accel=$ACCEL"
-command="$qemu $M -bios $FIRMWARE"
+command="$qemu -nodefaults $M -bios $FIRMWARE"
 command+=" -display none -serial stdio -kernel"
 command="$(timeout_cmd) $command"
 echo $command "$@"
diff --git a/x86/run b/x86/run
index 8c8fe7d3cc78..10a6e6d3421c 100755
--- a/x86/run
+++ b/x86/run
@@ -42,7 +42,7 @@ else
 	pc_testdev="-device testdev,chardev=testlog -chardev file,id=testlog,path=msr.out"
 fi
 
-command="${qemu} -enable-kvm $pc_testdev -vnc none -serial stdio $pci_testdev $hyperv_testdev -kernel"
+command="${qemu} -nodefaults -enable-kvm $pc_testdev -vnc none -serial stdio $pci_testdev $hyperv_testdev -kernel"
 command="$(timeout_cmd) $command"
 echo ${command} "$@"
 
-- 
2.7.4


             reply	other threads:[~2016-11-15 17:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 17:47 Andrew Jones [this message]
2016-11-16  1:51 ` [kvm-unit-tests PATCH] [RFC] run: add -nodefaults Thomas Huth
2016-11-17  9:40 ` Paolo Bonzini
2016-11-22 13:59 ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479232047-22195-1-git-send-email-drjones@redhat.com \
    --to=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).