From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: [kvm-unit-tests PATCH] [RFC] run: add -nodefaults Date: Tue, 15 Nov 2016 18:47:27 +0100 Message-ID: <1479232047-22195-1-git-send-email-drjones@redhat.com> Cc: rkrcmar@redhat.com, pbonzini@redhat.com, lvivier@redhat.com, thuth@redhat.com To: kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56956 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbcKORrb (ORCPT ); Tue, 15 Nov 2016 12:47:31 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1FE3831B31C for ; Tue, 15 Nov 2016 17:47:31 +0000 (UTC) Sender: kvm-owner@vger.kernel.org List-ID: Adding pci-test to arm allowed us to see that a virtio-net-pci device was getting added to our machine by default. Unit tests should configure the most minimal machines they can, only adding devices necessary for the tests. Let's add -nodefaults to all the run scripts. I tested all arches (powerpc and arm on tcg). There were no unexpected changes. Signed-off-by: Andrew Jones --- arm/run | 2 +- powerpc/run | 2 +- x86/run | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arm/run b/arm/run index 1ee6231599d6..f1b04af614dc 100755 --- a/arm/run +++ b/arm/run @@ -73,7 +73,7 @@ if $qemu $M -device '?' 2>&1 | grep pci-testdev > /dev/null; then fi M+=",accel=$ACCEL" -command="$qemu $M -cpu $processor $chr_testdev $pci_testdev" +command="$qemu -nodefaults $M -cpu $processor $chr_testdev $pci_testdev" command+=" -display none -serial stdio -kernel" command="$(timeout_cmd) $command" echo $command "$@" diff --git a/powerpc/run b/powerpc/run index 14988a75b1e2..afdd487bfc35 100755 --- a/powerpc/run +++ b/powerpc/run @@ -43,7 +43,7 @@ fi M='-machine pseries' M+=",accel=$ACCEL" -command="$qemu $M -bios $FIRMWARE" +command="$qemu -nodefaults $M -bios $FIRMWARE" command+=" -display none -serial stdio -kernel" command="$(timeout_cmd) $command" echo $command "$@" diff --git a/x86/run b/x86/run index 8c8fe7d3cc78..10a6e6d3421c 100755 --- a/x86/run +++ b/x86/run @@ -42,7 +42,7 @@ else pc_testdev="-device testdev,chardev=testlog -chardev file,id=testlog,path=msr.out" fi -command="${qemu} -enable-kvm $pc_testdev -vnc none -serial stdio $pci_testdev $hyperv_testdev -kernel" +command="${qemu} -nodefaults -enable-kvm $pc_testdev -vnc none -serial stdio $pci_testdev $hyperv_testdev -kernel" command="$(timeout_cmd) $command" echo ${command} "$@" -- 2.7.4