From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junaid Shahid Subject: [PATCH 4/5] kvm: x86: mmu: Update comment in mark_spte_for_access_track Date: Wed, 21 Dec 2016 20:29:31 -0800 Message-ID: <1482380972-25573-5-git-send-email-junaids@google.com> References: <1482380972-25573-1-git-send-email-junaids@google.com> Cc: andreslc@google.com, pfeiner@google.com, pbonzini@redhat.com, guangrong.xiao@linux.intel.com To: kvm@vger.kernel.org Return-path: Received: from mail-pg0-f48.google.com ([74.125.83.48]:35868 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755573AbcLVE3i (ORCPT ); Wed, 21 Dec 2016 23:29:38 -0500 Received: by mail-pg0-f48.google.com with SMTP id f188so92959006pgc.3 for ; Wed, 21 Dec 2016 20:29:37 -0800 (PST) In-Reply-To: <1482380972-25573-1-git-send-email-junaids@google.com> Sender: kvm-owner@vger.kernel.org List-ID: Reword the comment to hopefully make it more clear. Signed-off-by: Junaid Shahid --- arch/x86/kvm/mmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 76cc911..49a7fe4 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -707,9 +707,9 @@ static u64 mark_spte_for_access_track(u64 spte) return spte; /* - * Verify that the write-protection that we do below will be fixable - * via the fast page fault path. Currently, that is always the case, at - * least when using EPT (which is when access tracking would be used). + * Making an Access Tracking PTE will result in removal of write access + * from the PTE. So, verify that we will be able to restore the write + * access in the fast page fault path later on. */ WARN_ONCE((spte & PT_WRITABLE_MASK) && !spte_can_locklessly_be_made_writable(spte), -- 2.8.0.rc3.226.g39d4020