public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	marc.zyngier-5wv7dgnIgG8@public.gmane.org,
	robin.murphy-5wv7dgnIgG8@public.gmane.org,
	alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
	jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	punit.agrawal-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: [PATCH v6 17/18] vfio/type1: Check MSI remapping at irq domain level
Date: Thu,  5 Jan 2017 19:04:45 +0000	[thread overview]
Message-ID: <1483643086-2883-18-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1483643086-2883-1-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

In case the IOMMU translates MSI transactions (typical case
on ARM), we check MSI remapping capability at IRQ domain
level. Otherwise it is checked at IOMMU level.

At this stage the arm-smmu-(v3) still advertise the
IOMMU_CAP_INTR_REMAP capability at IOMMU level. This will be
removed in subsequent patches.

Signed-off-by: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

---

v6: rewrite test
---
 drivers/vfio/vfio_iommu_type1.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index b473ef80..fa0b5c4 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -40,6 +40,7 @@
 #include <linux/mdev.h>
 #include <linux/notifier.h>
 #include <linux/dma-iommu.h>
+#include <linux/irqdomain.h>
 
 #define DRIVER_VERSION  "0.2"
 #define DRIVER_AUTHOR   "Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>"
@@ -1208,7 +1209,7 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
 	struct vfio_domain *domain, *d;
 	struct bus_type *bus = NULL, *mdev_bus;
 	int ret;
-	bool resv_msi;
+	bool resv_msi, msi_remap;
 	phys_addr_t resv_msi_base;
 
 	mutex_lock(&iommu->lock);
@@ -1284,8 +1285,10 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
 	INIT_LIST_HEAD(&domain->group_list);
 	list_add(&group->next, &domain->group_list);
 
-	if (!allow_unsafe_interrupts &&
-	    !iommu_capable(bus, IOMMU_CAP_INTR_REMAP)) {
+	msi_remap = resv_msi ? irq_domain_check_msi_remap() :
+				iommu_capable(bus, IOMMU_CAP_INTR_REMAP);
+
+	if (!allow_unsafe_interrupts && !msi_remap) {
 		pr_warn("%s: No interrupt remapping support.  Use the module param \"allow_unsafe_interrupts\" to enable VFIO IOMMU support on this platform\n",
 		       __func__);
 		ret = -EPERM;
-- 
1.9.1

  parent reply	other threads:[~2017-01-05 19:04 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05 19:04 [PATCH v6 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Eric Auger
     [not found] ` <1483643086-2883-1-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-05 19:04   ` [PATCH v6 01/18] iommu/dma: Allow MSI-only cookies Eric Auger
     [not found]     ` <1483643086-2883-2-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-06 10:59       ` Joerg Roedel
     [not found]         ` <20170106105945.GK17255-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-06 11:46           ` Auger Eric
     [not found]             ` <b058a7f9-84bf-1d5c-1c24-24da251cc964-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-06 12:12               ` Robin Murphy
     [not found]                 ` <ae222579-6939-b89a-80c2-9ee8f147299e-5wv7dgnIgG8@public.gmane.org>
2017-01-06 13:05                   ` Auger Eric
2017-01-05 19:04   ` [PATCH v6 02/18] iommu: Rename iommu_dm_regions into iommu_resv_regions Eric Auger
2017-01-05 19:04   ` [PATCH v6 03/18] iommu: Add a new type field in iommu_resv_region Eric Auger
2017-01-05 19:04   ` [PATCH v6 04/18] iommu: iommu_alloc_resv_region Eric Auger
2017-01-05 19:04   ` [PATCH v6 05/18] iommu: Only map direct mapped regions Eric Auger
2017-01-05 19:04   ` [PATCH v6 06/18] iommu: iommu_get_group_resv_regions Eric Auger
2017-01-05 19:04   ` [PATCH v6 07/18] iommu: Implement reserved_regions iommu-group sysfs file Eric Auger
     [not found]     ` <1483643086-2883-8-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-06 11:00       ` Joerg Roedel
     [not found]         ` <20170106110039.GL17255-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-06 11:46           ` Auger Eric
     [not found]             ` <888d3750-817c-77d1-8154-e77cf8c3ad4b-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-06 12:48               ` Joerg Roedel
     [not found]                 ` <20170106124816.GQ17255-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-06 13:04                   ` Auger Eric
2017-01-06 17:18                   ` Auger Eric
     [not found]                     ` <0858b719-2888-0645-66d2-56fe698f4e2f-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-08 16:26                       ` Auger Eric
2017-01-05 19:04   ` [PATCH v6 08/18] iommu/vt-d: Implement reserved region get/put callbacks Eric Auger
     [not found]     ` <1483643086-2883-9-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-06 11:01       ` Joerg Roedel
     [not found]         ` <20170106110131.GM17255-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-06 11:45           ` Auger Eric
     [not found]             ` <36bac0a9-89a6-ff7b-1870-a795a4f57700-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-06 12:46               ` Joerg Roedel
     [not found]                 ` <20170106124631.GP17255-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-01-06 13:03                   ` Auger Eric
2017-01-05 19:04   ` [PATCH v6 09/18] iommu/amd: Declare MSI and HT regions as reserved IOVA regions Eric Auger
2017-01-05 19:04   ` [PATCH v6 10/18] iommu/arm-smmu: Implement reserved region get/put callbacks Eric Auger
2017-01-05 19:04   ` [PATCH v6 11/18] iommu/arm-smmu-v3: " Eric Auger
2017-01-05 19:04   ` [PATCH v6 12/18] irqdomain: Add irq domain MSI and MSI_REMAP flags Eric Auger
2017-01-05 19:04   ` [PATCH v6 13/18] genirq/msi: Set IRQ_DOMAIN_FLAG_MSI on MSI domain creation Eric Auger
2017-01-05 19:04   ` [PATCH v6 14/18] irqdomain: irq_domain_check_msi_remap Eric Auger
2017-01-05 19:04   ` [PATCH v6 15/18] irqchip/gicv3-its: Sets IRQ_DOMAIN_FLAG_MSI_REMAP Eric Auger
2017-01-05 19:04   ` [PATCH v6 16/18] vfio/type1: Allow transparent MSI IOVA allocation Eric Auger
2017-01-05 19:04   ` Eric Auger [this message]
2017-01-06  8:50     ` [PATCH v6 17/18] vfio/type1: Check MSI remapping at irq domain level Bharat Bhushan
     [not found]       ` <AM5PR0401MB25454B0C8F6E610A50B299D19A630-oQ3wXcTHOqrg6d/1FbYcvI3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-01-06  9:08         ` Auger Eric
     [not found]           ` <af612e18-ca0b-b855-e198-d4c706f2febc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-06  9:20             ` Marc Zyngier
     [not found]               ` <845d7167-6734-03c9-4df6-2f82f1627dbc-5wv7dgnIgG8@public.gmane.org>
2017-01-06  9:31                 ` Bharat Bhushan
2017-01-05 19:04   ` [PATCH v6 18/18] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Eric Auger
2017-01-06 11:02   ` [PATCH v6 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483643086-2883-18-git-send-email-eric.auger@redhat.com \
    --to=eric.auger-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
    --cc=pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=punit.agrawal-5wv7dgnIgG8@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    --cc=shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox