From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
marc.zyngier@arm.com, christoffer.dall@linaro.org,
andre.przywara@arm.com, vijayak@caviumnetworks.com,
Vijaya.Kumar@cavium.com, peter.maydell@linaro.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Cc: Prasun.Kapoor@cavium.com, quintela@redhat.com,
dgilbert@redhat.com, pbonzini@redhat.com
Subject: [PATCH v4 01/22] KVM: arm/arm64: Add vITS save/restore API documentation
Date: Mon, 27 Mar 2017 11:30:51 +0200 [thread overview]
Message-ID: <1490607072-21610-2-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1490607072-21610-1-git-send-email-eric.auger@redhat.com>
Add description for how to access vITS registers and how to flush/restore
vITS tables into/from memory
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
v3 -> v4:
- take into account Peter's comments:
- typos
- KVM_DEV_ARM_VGIC_GRP_ITS_TABLES kvm_device_attr = 0
- add a validity bit in DTE
- document all fields in CTE and ITE
- document ABI revision
- take into account Andre's comments:
- document restrictions about GITS_CREADR writing and GITS_IIDR
- document -EBUSY error if one or more VCPUS are runnning
- document 64b registers only can be accessed with 64b access
- itt_addr field matches bits [51:8] of the itt_addr
v1 -> v2:
- DTE and ITE now are 8 bytes
- DTE and ITE now indexed by deviceid/eventid
- use ITE name instead of ITTE
- mentions ITT_addr matches bits [51:8] of the actual address
- mentions LE layout
---
Documentation/virtual/kvm/devices/arm-vgic-its.txt | 118 +++++++++++++++++++++
1 file changed, 118 insertions(+)
diff --git a/Documentation/virtual/kvm/devices/arm-vgic-its.txt b/Documentation/virtual/kvm/devices/arm-vgic-its.txt
index 6081a5b..0902d20 100644
--- a/Documentation/virtual/kvm/devices/arm-vgic-its.txt
+++ b/Documentation/virtual/kvm/devices/arm-vgic-its.txt
@@ -36,3 +36,121 @@ Groups:
-ENXIO: ITS not properly configured as required prior to setting
this attribute
-ENOMEM: Memory shortage when allocating ITS internal data
+
+ KVM_DEV_ARM_VGIC_GRP_ITS_REGS
+ Attributes:
+ The attr field of kvm_device_attr encodes the offset of the
+ ITS register, relative to the ITS control frame base address
+ (ITS_base).
+
+ kvm_device_attr.addr points to a __u64 value whatever the width
+ of the addressed register (32/64 bits). 64 bit registers can only
+ be accessed with full length.
+
+ Writes to read-only registers are ignored by the kernel except for:
+ - GITS_READR. It needs to be restored otherwise commands in the queue
+ will be re-executed after CWRITER setting. Writing this register is
+ allowed if the ITS is not enabled (GITS_CTLR.enable = 0). Also it
+ needs to be restored after GITS_CBASER since a write to GITS_CBASER
+ resets GITS_CREADR.
+ - GITS_IIDR. Its Revision field encodes the table layout ABI revision.
+
+ For other registers, getting or setting a register has the same
+ effect as reading/writing the register on real hardware.
+ Errors:
+ -ENXIO: Offset does not correspond to any supported register
+ -EFAULT: Invalid user pointer for attr->addr
+ -EINVAL: Offset is not 64-bit aligned
+ -EBUSY: one or more VCPUS are running
+
+ KVM_DEV_ARM_VGIC_GRP_ITS_TABLES
+ Attributes
+ The attr field of kvm_device_attr must be zero.
+
+ request the flush-save/restore of the ITS tables, namely
+ the device table, the collection table, all the ITT tables,
+ the LPI pending tables. On save, the tables are flushed
+ into guest memory at the location provisioned by the guest
+ in GITS_BASER (device and collection tables), in the MAPD
+ command (ITT_addr), GICR_PENDBASERs (pending tables).
+
+ This means the GIC should be restored before the ITS and all
+ ITS registers but the GITS_CTLR must be restored before
+ restoring the ITS tables.
+
+ The GITS_READR and GITS_IIDR read-only registers must also
+ be restored before the table restore. The IIDR revision field
+ encodes the ABI revision of the table layout. If not set by
+ user space, the restoration of the tables will fail.
+
+ Note the LPI configuration table is read-only for the
+ in-kernel ITS and its save/restore goes through the standard
+ RAM save/restore.
+
+ The layout of the tables in guest memory defines an ABI.
+ The entries are laid in little endian format as follows;
+
+ Errors:
+ -EINVAL: kvm_device_attr not equal to 0, invalid table data
+ -EFAULT: invalid guest ram access
+ -EBUSY: one or more VCPUS are running
+
+ ITS Table ABI REV1:
+ -------------------
+
+ The device table and ITE are respectively indexed by device id and
+ eventid. The collection table however is not indexed by collection id:
+ CTE are written at the beginning of the buffer.
+
+ Device Table Entry (DTE) layout: entry size = 8 bytes
+
+ bits: | 63| 62 ... 49 | 48 ... 5 | 4 ... 0 |
+ values: | V | next | ITT_addr | Size |
+
+ where;
+ - V indicates whether the entry is valid,
+ - ITT_addr matches bits [51:8] of the ITT address (256B aligned),
+ - next field is meaningful only if the entry is valid.
+ It equals to 0 if this entry is the last one; otherwise it corresponds
+ to the minimum between the offset to the next device id and 2^14 -1.
+
+ Collection Table Entry (CTE) layout: entry size = 8 bytes
+
+ bits: | 63| 62 .. 52 | 51 ... 16 | 15 ... 0 |
+ values: | V | RES0 | RDBase | ICID |
+
+ where:
+ - V indicates whether the entry is valid,
+ - RDBase matches the PE number (GICR_TYPER.Processor_Number),
+ - ICID matches the collection ID
+
+ Interrupt Translation Entry (ITE) layout: entry size = 8 bytes
+
+ bits: | 63 ... 48 | 47 ... 16 | 15 ... 0 |
+ values: | next | pINTID | ICID |
+
+ where:
+ - pINTID is the physical LPI ID,
+ - ICID is the collection ID,
+ - next field is meaningful only if the entry is valid (pINTID != 0).
+ It equals to 0 if this entry is the last one; otherwise it corresponds
+ to the minimum between the eventid offset to the next ITE and 2^16 -1.
+
+ LPI Pending Table layout:
+
+ As specified in the ARM Generic Interrupt Controller Architecture
+ Specification GIC Architecture version 3.0 and version 4. The first
+ 1kB is not modified and therefore should contain zeroes.
+
+ Future evolutions of the ITS table layout:
+
+ At the moment the table layout is defined and optimized for physical
+ LPI support.
+
+ In the future we might implement direct injection of virtual LPIS.
+ This will require an upgrade of the table layout and an evolution of
+ the ABI. The ABI revision is encoded in the GITS_IIDR revision field.
+ That register must be restored before the table restoration, otherwise
+ the operation will fail.
+
+ ABI V1: GITS_IIDR.Revision = 1
--
2.5.5
next prev parent reply other threads:[~2017-03-27 9:30 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 9:30 [PATCH v4 00/22] vITS save/restore Eric Auger
2017-03-27 9:30 ` Eric Auger [this message]
2017-04-08 10:03 ` [PATCH v4 01/22] KVM: arm/arm64: Add vITS save/restore API documentation Marc Zyngier
2017-04-08 13:15 ` Christoffer Dall
2017-04-08 17:31 ` Marc Zyngier
2017-04-10 10:18 ` Auger Eric
2017-04-10 10:42 ` Marc Zyngier
2017-04-08 18:17 ` Christoffer Dall
2017-04-10 14:26 ` Auger Eric
2017-04-21 9:12 ` Christoffer Dall
2017-03-27 9:30 ` [PATCH v4 02/22] KVM: arm/arm64: rename itte into ite Eric Auger
2017-04-08 10:04 ` Marc Zyngier
2017-03-27 9:30 ` [PATCH v4 03/22] arm/arm64: vgic: turn vgic_find_mmio_region into public Eric Auger
2017-04-08 10:06 ` Marc Zyngier
2017-03-27 9:30 ` [PATCH v4 04/22] KVM: arm64: ITS: KVM_DEV_ARM_VGIC_GRP_ITS_REGS group Eric Auger
2017-04-08 10:07 ` Marc Zyngier
2017-03-27 9:30 ` [PATCH v4 05/22] KVM: arm/arm64: vgic: expose (un)lock_all_vcpus Eric Auger
2017-04-08 10:09 ` Marc Zyngier
2017-03-27 9:30 ` [PATCH v4 06/22] KVM: arm64: ITS: Implement vgic_its_has_attr_regs and attr_regs_access Eric Auger
2017-04-08 10:24 ` Marc Zyngier
2017-03-27 9:30 ` [PATCH v4 07/22] KVM: arm64: ITS: Implement vgic_mmio_uaccess_write_its_creadr Eric Auger
2017-04-08 10:36 ` Marc Zyngier
2017-03-27 9:30 ` [PATCH v4 08/22] KVM: arm64: ITS: Implement vgic_mmio_uaccess_write_its_iidr Eric Auger
2017-04-08 10:42 ` Marc Zyngier
2017-04-10 14:32 ` Auger Eric
2017-04-10 14:57 ` Marc Zyngier
2017-04-10 15:07 ` Peter Maydell
2017-04-10 15:17 ` Auger Eric
2017-04-11 10:05 ` Marc Zyngier
2017-04-11 10:08 ` Auger Eric
2017-04-11 10:16 ` Peter Maydell
2017-04-11 10:29 ` Marc Zyngier
2017-04-11 10:43 ` Peter Maydell
2017-04-11 10:56 ` Auger Eric
2017-03-27 9:30 ` [PATCH v4 09/22] KVM: arm64: ITS: Report the ITE size in GITS_TYPER Eric Auger
2017-04-08 17:42 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 10/22] KVM: arm64: ITS: Interpret MAPD Size field and check related errors Eric Auger
2017-04-08 17:59 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 11/22] KVM: arm64: ITS: Interpret MAPD ITT_addr field Eric Auger
2017-04-08 18:58 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 12/22] KVM: arm64: ITS: Check the device id matches TYPER DEVBITS range Eric Auger
2017-03-27 9:31 ` [PATCH v4 13/22] KVM: arm64: ITS: KVM_DEV_ARM_VGIC_GRP_ITS_TABLES group Eric Auger
2017-03-27 15:04 ` kbuild test robot
2017-03-27 18:29 ` Auger Eric
2017-03-30 2:21 ` [kbuild-all] " Ye Xiaolong
2017-03-30 6:46 ` Auger Eric
2017-03-30 7:29 ` Ye Xiaolong
2017-03-30 8:29 ` Auger Eric
2017-04-09 10:09 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 14/22] KVM: arm64: ITS: vgic_its_alloc_ite/device Eric Auger
2017-04-09 10:13 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 15/22] KVM: arm64: ITS: Sort the device and ITE lists Eric Auger
2017-04-09 10:18 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 16/22] KVM: expose next_segment() Eric Auger
2017-03-27 9:31 ` [PATCH v4 17/22] KVM: arm64: ITS: Add infrastructure for table lookup Eric Auger
2017-04-09 10:36 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 18/22] KVM: arm64: ITS: Collection table save/restore Eric Auger
2017-04-10 9:55 ` Marc Zyngier
2017-04-11 9:57 ` Auger Eric
2017-04-11 10:03 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 19/22] KVM: arm64: ITS: vgic_its_check_id returns the entry's GPA Eric Auger
2017-03-27 9:31 ` [PATCH v4 20/22] KVM: arm64: ITS: ITT flush and restore Eric Auger
2017-04-10 12:39 ` Marc Zyngier
2017-04-11 10:19 ` Auger Eric
2017-03-27 9:31 ` [PATCH v4 21/22] KVM: arm64: ITS: Device table save/restore Eric Auger
2017-04-10 12:42 ` Marc Zyngier
2017-03-27 9:31 ` [PATCH v4 22/22] KVM: arm64: ITS: Pending " Eric Auger
2017-04-10 12:50 ` Marc Zyngier
2017-04-10 12:54 ` [PATCH v4 00/22] vITS save/restore Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490607072-21610-2-git-send-email-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=Prasun.Kapoor@cavium.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=andre.przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=dgilbert@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=quintela@redhat.com \
--cc=vijayak@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).