From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, lei.cao@stratus.com
Subject: [PATCH 0/3] kvm: API adjustments for dirty page ring patches
Date: Fri, 31 Mar 2017 13:53:21 +0200 [thread overview]
Message-ID: <1490961203-7139-1-git-send-email-pbonzini@redhat.com> (raw)
As posted, the patches for the dirty page ring broke non-x86
architectures, because it moved KVM_COALESCED_MMIO_PAGE_OFFSET
incorrectly to include/uapi/linux/kvm.h.
In file included from include/linux/kvm_host.h:36:0,
from arch/arm64/kernel/hibernate.c:19:
>> arch/arm64/include/asm/kvm_host.h:35:0: warning: "KVM_COALESCED_MMIO_PAGE_OFFSET" redefined
#define KVM_COALESCED_MMIO_PAGE_OFFSET 1
In file included from include/linux/kvm_host.h:31:0,
from arch/arm64/kernel/hibernate.c:19:
include/uapi/linux/kvm.h:218:0: note: this is the location of the previous definition
#define KVM_COALESCED_MMIO_PAGE_OFFSET 2
This fixes it by moving it to each architecture's UAPI headers
separately.
Paolo
Paolo Bonzini (2):
kvm: make KVM_CAP_COALESCED_MMIO architecture agnostic
kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public
arch/arm/include/asm/kvm_host.h | 1 -
arch/arm/include/uapi/asm/kvm.h | 2 ++
arch/arm/kvm/arm.c | 3 ---
arch/arm64/include/asm/kvm_host.h | 1 -
arch/arm64/include/uapi/asm/kvm.h | 2 ++
arch/mips/include/asm/kvm_host.h | 1 -
arch/mips/include/uapi/asm/kvm.h | 2 ++
arch/mips/kvm/mips.c | 3 ---
arch/powerpc/include/asm/kvm_host.h | 3 ---
arch/powerpc/include/uapi/asm/kvm.h | 3 +++
arch/powerpc/kvm/powerpc.c | 5 -----
arch/x86/include/asm/kvm_host.h | 2 --
arch/x86/include/uapi/asm/kvm.h | 3 +++
arch/x86/kvm/x86.c | 3 ---
include/linux/kvm_host.h | 2 +-
virt/kvm/kvm_main.c | 13 +++++++++----
16 files changed, 22 insertions(+), 27 deletions(-)
--
1.8.3.1
next reply other threads:[~2017-03-31 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 11:53 Paolo Bonzini [this message]
2017-03-31 11:53 ` [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture agnostic Paolo Bonzini
2017-03-31 13:21 ` Radim Krčmář
2017-03-31 13:41 ` Radim Krčmář
2017-04-03 11:29 ` David Hildenbrand
2017-03-31 11:53 ` [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public Paolo Bonzini
2017-03-31 13:39 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490961203-7139-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lei.cao@stratus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox