[RFC PATCH 20/20] intel_iommu: propagate Ext-Device-TLB invalidate to host

Liu, Yi L
2017-04-26T10:25:05Z

For Extended-Device-TLB invalidation, intel_iommu emulator needs to check
all the assigned device and find the affected device. Replace the guest
SID with the host SID in the invalidate descriptor and pass the request to
host.

Host may just submit the request to corresponding invalidation queue in
pIOMMU. In future maybe PASID needs to be replaced.

Signed-off-by: Liu, Yi L <yi.l.liu@linux.intel.com>
---
hw/i386/intel_iommu.c | 43 ++++++++++++++++++++++++++++++++++++++++++
hw/i386/intel_iommu_internal.h | 7 +++++++
2 files changed, 50 insertions(+)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index c5e9170..4370790 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2012,6 +2012,13 @@ static void vtd_tlb_inv_notify_hook(VTDNotifierIterator *iter,
} else {
return;
}
+ case VTD_INV_DESC_EXT_DIOTLB:
+ if (iter->sid != *tlb_hook_info->sid) {
+ return;
+ }
+ tlb_hook_info->inv_desc->lo &= ~VTD_INV_DESC_EXT_DIOTLB_SID_MASK;
+ tlb_hook_info->inv_desc->lo |= (iter->host_sid << 16);
+ break;
default:
return;
}
@@ -2147,6 +2154,34 @@ static bool vtd_process_pasid_desc(IntelIOMMUState *s,
return true;
}

+static bool vtd_process_ext_device_iotlb(IntelIOMMUState *s,
+ VTDInvDesc *inv_desc)
+{
+ uint32_t pasid;
+ uint16_t sid;
+ VTDIOTLBInvHookInfo tlb_hook_info;
+
+ if ((inv_desc->lo & VTD_INV_DESC_EXT_DIOTLB_RSVD_LO) ||
+ (inv_desc->hi & VTD_INV_DESC_EXT_DIOTLB_RSVD_HI)) {
+ VTD_DPRINTF(GENERAL, "error: non-zero reserved field in"
+ " Device ExIOTLB desc, hi 0x%"PRIx64 " lo 0x%"PRIx64,
+ inv_desc->hi, inv_desc->lo);
+ return false;
+ }
+
+ pasid = VTD_INV_DESC_EXT_DIOTLB_PASID(inv_desc->lo);
+ sid = VTD_INV_DESC_EXT_DIOTLB_SID(inv_desc->lo);
+
+ tlb_hook_info.did = NULL;
+ tlb_hook_info.sid = &sid;
+ tlb_hook_info.pasid = &pasid;
+ tlb_hook_info.inv_desc = inv_desc;
+ vtd_tlb_inv_passdown_notify(s,
+ &tlb_hook_info,
+ vtd_tlb_inv_notify_hook);
+ return true;
+}
+
static bool vtd_process_inv_desc(IntelIOMMUState *s)
{
VTDInvDesc inv_desc;
@@ -2190,6 +2225,14 @@ static bool vtd_process_inv_desc(IntelIOMMUState *s)
}
break;

+ case VTD_INV_DESC_EXT_DIOTLB:
+ trace_vtd_inv_desc("device-extended-iotlb",
+ inv_desc.hi, inv_desc.lo);
+ if (!vtd_process_ext_device_iotlb(s, &inv_desc)) {
+ return false;
+ }
+ break;
+
case VTD_INV_DESC_WAIT:
trace_vtd_inv_desc("wait", inv_desc.hi, inv_desc.lo);
if (!vtd_process_wait_desc(s, &inv_desc)) {
diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
index a6b9350..3cb2361 100644
--- a/hw/i386/intel_iommu_internal.h
+++ b/hw/i386/intel_iommu_internal.h
@@ -343,6 +343,7 @@ typedef union VTDInvDesc VTDInvDesc;
#define VTD_INV_DESC_WAIT 0x5 /* Invalidation Wait Descriptor */
#define VTD_INV_DESC_EXT_IOTLB 0x6 /* Ext-IOTLB Invalidate Desc */
#define VTD_INV_DESC_PC 0x7 /* PASID-cache Invalidate Desc */
+#define VTD_INV_DESC_EXT_DIOTLB 0x8 /* Ext-DIOTLB Invalidate Desc */
#define VTD_INV_DESC_NONE 0 /* Not an Invalidate Descriptor */

/* Masks for Invalidation Wait Descriptor*/
@@ -407,6 +408,12 @@ typedef union VTDInvDesc VTDInvDesc;
#define VTD_INV_DESC_PASIDC_ALL_ALL (0ULL << 4)
#define VTD_INV_DESC_PASIDC_PASID_SI (1ULL << 4)

+#define VTD_INV_DESC_EXT_DIOTLB_PASID(val) (((val) >> 32) & 0xfffffULL)
+#define VTD_INV_DESC_EXT_DIOTLB_SID(val) (((val) >> 16) & 0xffff)
+#define VTD_INV_DESC_EXT_DIOTLB_RSVD_LO 0xe00ULL
+#define VTD_INV_DESC_EXT_DIOTLB_RSVD_HI 0x7feULL
+#define VTD_INV_DESC_EXT_DIOTLB_SID_MASK 0xFFFF0000ULL
+
/* Information about page-selective IOTLB invalidate */
struct VTDIOTLBPageInvInfo {
uint16_t domain_id;
--
1.9.1