From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: [kvm-unit-tests PATCH] s390x/intercept: Fix problem with bad compiler warning Date: Tue, 27 Jun 2017 06:18:15 +0200 Message-ID: <1498537095-627-1-git-send-email-thuth@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Drew Jones To: David Hildenbrand , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36590 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbdF0ESU (ORCPT ); Tue, 27 Jun 2017 00:18:20 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 331497EBD2 for ; Tue, 27 Jun 2017 04:18:20 +0000 (UTC) Sender: kvm-owner@vger.kernel.org List-ID: The intercept test currently can not be compiled with GCC 4.8 anymore. It generates the following warning (which is fatal due to -Werror): s390x/intercept.c: In function ‘test_stidp’: s390x/intercept.c:111:9: error: missing initializer for field ‘version’ of ‘struct cpuid’ [-Werror=missing-field-initializers] struct cpuid id = {}; ^ Fix it by using a "0" as intializer here. Signed-off-by: Thomas Huth --- NB: We could also remove the -Wextra from the CFLAGS instead. IMHO using -Wextra together with -Werror is just like playing Russian roulette. Since -Wextra is some kind of "compiler warning playground" for the GCC folks, you never know which compiler version will trigger an unexpected (and often also unfounded) warning here, so using this together with -Werror is just a nuisance. s390x/intercept.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s390x/intercept.c b/s390x/intercept.c index 9766289..9fe86cf 100644 --- a/s390x/intercept.c +++ b/s390x/intercept.c @@ -108,7 +108,7 @@ static void test_stap(void) /* Test the STORE CPU ID instruction */ static void test_stidp(void) { - struct cpuid id = {}; + struct cpuid id = { 0 }; asm volatile ("stidp %0\n" : "+Q"(id)); report("type set", id.type); -- 1.8.3.1