From: Rik van Riel <riel@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>, Nitesh Narayan Lal <nilal@redhat.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, david@redhat.com,
yang zhang wz <yang.zhang.wz@gmail.com>,
wei w wang <wei.w.wang@intel.com>
Subject: Re: [PATCH 2/3] KVM: Guest page hinting functionality
Date: Wed, 02 Aug 2017 11:02:38 -0400 [thread overview]
Message-ID: <1501686158.26846.53.camel@redhat.com> (raw)
In-Reply-To: <1994464898.38151926.1501676382421.JavaMail.zimbra@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Wed, 2017-08-02 at 08:19 -0400, Pankaj Gupta wrote:
> >
> > + write_seqlock(&guest_page_lock);
> > + while (idx < MAX_FGPT_ENTRIES) {
> > + unsigned long pfn = free_page_obj[idx].pfn;
> > + unsigned long pfn_end = free_page_obj[idx].pfn +
> > + free_page_obj[idx].pages -
> > 1;
> > + bool prev_free = false;
> > +
> > + while (pfn <= pfn_end) {
> > + struct page *p = pfn_to_page(pfn);
>
> just one thing here, if we want/planning to use pmem as RAM this
> might not work, because pfn will not
> have corresponding 'struct page'?
pmem is never really used as RAM; allocating
and freeing space in pmem is done by a filesystem,
not by the memory management subsystem.
--
All rights reversed
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-08-02 15:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 20:48 [PATCH 0/3] [RFC] KVM: Guest page hinting Nitesh Narayan Lal
2017-08-01 20:48 ` [PATCH 1/3] KVM: Support for guest " Nitesh Narayan Lal
2017-08-02 7:12 ` kbuild test robot
2017-08-01 20:48 ` [PATCH 2/3] KVM: Guest page hinting functionality Nitesh Narayan Lal
2017-08-02 7:01 ` Pankaj Gupta
2017-08-02 18:59 ` Nitesh Narayan Lal
2017-08-02 19:20 ` Rik van Riel
2017-08-02 20:37 ` Nitesh Narayan Lal
2017-08-02 12:19 ` Pankaj Gupta
2017-08-02 15:02 ` Rik van Riel [this message]
2017-08-01 20:48 ` [PATCH 3/3] KVM: Adding tracepoints for guest page hinting Nitesh Narayan Lal
2017-08-04 5:16 ` [PATCH 0/3] [RFC] KVM: Guest " Yang Zhang
2017-08-04 11:59 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501686158.26846.53.camel@redhat.com \
--to=riel@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pagupta@redhat.com \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox