From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH v1] kvm: drop wrong assertion creating problems with pflash Date: Thu, 21 Sep 2017 08:49:56 +0200 Message-ID: <1505976596.7353.0.camel@redhat.com> References: <20170920145025.19403-1-david@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: Paolo Bonzini , Radim =?UTF-8?Q?Kr=C4=8Dm=C3=A1=C5=99?= , kvm@vger.kernel.org To: David Hildenbrand , qemu-devel@nongnu.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43632 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbdIUGuA (ORCPT ); Thu, 21 Sep 2017 02:50:00 -0400 In-Reply-To: <20170920145025.19403-1-david@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2017-09-20 at 16:50 +0200, David Hildenbrand wrote: > pflash toggles mr->romd_mode. So this assert does not always hold. > > 1) a device was added with !mr->romd_mode, therefore effectively not >    creating a kvm slot as we want to trap every access (add = false). > 2) mr->romd_mode was toggled on before remove it. There is now >    actually no slot to remove and the asser is wrong. > > So let's just drop the assert. Works without any obvious bad side effects. Tested-by: Gerd Hoffmann cheers, Gerd