From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
marc.zyngier@arm.com, cdall@linaro.org, peter.maydell@linaro.org,
andre.przywara@arm.com, wanghaibin.wang@huawei.com
Cc: wu.wubin@huawei.com
Subject: [PATCH v2 01/10] KVM: arm/arm64: vgic-its: fix return value for restore
Date: Wed, 27 Sep 2017 15:28:31 +0200 [thread overview]
Message-ID: <1506518920-18571-2-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1506518920-18571-1-git-send-email-eric.auger@redhat.com>
From: wanghaibin <wanghaibin.wang@huawei.com>
This patch fix the migrate restore tables failure.
The same scene, at the destination, the restore tables
interface traversal guest memory, and check the dte/ite
is valid or not. If all dtes/ites are invalid, we will do
try next one, and the last it will take the 1 return value,
but currently, it be treated as error. That's not correct.
This patch try to fix this problem.
Signed-off-by: wanghaibin <wanghaibin.wang@huawei.com>
---
need to CC stable
v1 -> v2:
- if (ret > 0) ret = 0
---
virt/kvm/arm/vgic/vgic-its.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
index f51c1e1..fbbc97b 100644
--- a/virt/kvm/arm/vgic/vgic-its.c
+++ b/virt/kvm/arm/vgic/vgic-its.c
@@ -2018,7 +2018,7 @@ static int vgic_its_restore_dte(struct vgic_its *its, u32 id,
return PTR_ERR(dev);
ret = vgic_its_restore_itt(its, dev);
- if (ret) {
+ if (ret < 0) {
vgic_its_free_device(its->dev->kvm, dev);
return ret;
}
@@ -2141,7 +2141,7 @@ static int vgic_its_restore_device_tables(struct vgic_its *its)
}
if (ret > 0)
- ret = -EINVAL;
+ ret = 0;
return ret;
}
--
2.5.5
next prev parent reply other threads:[~2017-09-27 13:28 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 13:28 [PATCH v2 00/10] vITS Migration fixes and reset Eric Auger
2017-09-27 13:28 ` Eric Auger [this message]
2017-10-06 14:37 ` [PATCH v2 01/10] KVM: arm/arm64: vgic-its: fix return value for restore Andre Przywara
2017-10-06 15:33 ` Auger Eric
2017-10-13 11:04 ` Christoffer Dall
2017-09-27 13:28 ` [PATCH v2 02/10] KVM: arm/arm64: vgic-its: Always allow clearing GITS_CREADR/CWRITER Eric Auger
2017-10-06 14:37 ` Andre Przywara
2017-10-06 15:29 ` Auger Eric
2017-10-13 11:44 ` Christoffer Dall
2017-10-13 11:54 ` Auger Eric
2017-10-13 17:54 ` Christoffer Dall
2017-10-14 8:53 ` Auger Eric
2017-10-14 15:04 ` Christoffer Dall
2017-09-27 13:28 ` [PATCH v2 03/10] KVM: arm/arm64: vgic-its: Improve error reporting on device table save Eric Auger
2017-10-06 14:38 ` Andre Przywara
2017-10-13 13:16 ` Christoffer Dall
2017-10-13 14:22 ` Auger Eric
2017-10-13 17:56 ` Christoffer Dall
2017-10-14 8:52 ` Auger Eric
2017-10-14 15:06 ` Christoffer Dall
2017-09-27 13:28 ` [PATCH v2 04/10] KVM: arm/arm64: vgic-its: Check GITS_BASER Valid bit before saving tables Eric Auger
2017-10-06 14:38 ` Andre Przywara
2017-10-13 13:24 ` Christoffer Dall
2017-09-27 13:28 ` [PATCH v2 05/10] KVM: arm/arm64: vgic-its: Check GITS_CBASER validity before processing commands Eric Auger
2017-10-06 14:38 ` Andre Przywara
2017-10-06 15:29 ` Auger Eric
2017-09-27 13:28 ` [PATCH v2 06/10] KVM: arm/arm64: vgic-its: Always attempt to save/restore device and collection tables Eric Auger
2017-10-06 14:38 ` Andre Przywara
2017-10-06 15:29 ` Auger Eric
2017-09-27 13:28 ` [PATCH v2 07/10] KVM: arm/arm64: vgic-its: new helper functions to free the caches Eric Auger
2017-10-13 13:35 ` Christoffer Dall
2017-10-13 14:37 ` Auger Eric
2017-10-21 9:02 ` Auger Eric
2017-10-21 14:34 ` Christoffer Dall
2017-09-27 13:28 ` [PATCH v2 08/10] KVM: arm/arm64: vgic-its: free caches when GITS_BASER Valid bit is cleared Eric Auger
2017-10-13 15:19 ` Christoffer Dall
2017-10-13 15:34 ` Auger Eric
2017-10-13 17:59 ` Christoffer Dall
2017-09-27 13:28 ` [PATCH v2 09/10] KVM: arm/arm64: Document KVM_DEV_ARM_ITS_CTRL_RESET Eric Auger
2017-10-12 10:57 ` Peter Maydell
2017-10-12 11:34 ` Auger Eric
2017-10-13 15:26 ` Christoffer Dall
2017-10-13 15:41 ` Auger Eric
2017-10-13 18:00 ` Christoffer Dall
2017-09-27 13:28 ` [PATCH v2 10/10] KVM: arm/arm64: vgic-its: Implement KVM_DEV_ARM_ITS_CTRL_RESET Eric Auger
2017-10-13 15:40 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506518920-18571-2-git-send-email-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=andre.przywara@arm.com \
--cc=cdall@linaro.org \
--cc=eric.auger.pro@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
--cc=wanghaibin.wang@huawei.com \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox