public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>,
	Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	kvm@vger.kernel.org, Eric Auger <eric.auger@redhat.com>
Subject: Re: [RFC PATCH kernel] vfio-pci: Allow write combining
Date: Tue, 14 Nov 2017 13:29:02 +1100	[thread overview]
Message-ID: <1510626542.2397.8.camel@kernel.crashing.org> (raw)
In-Reply-To: <20171114022350.GA20747@umbus.fritz.box>

On Tue, 2017-11-14 at 13:23 +1100, David Gibson wrote:
> > >> 1. Allow msix mapping to the userspace (to address non-64k-aligned msix bar)
> 
> We have a new plan on this - I'll discuss it over IRC.
> 
> > >> 2. Allow write combining in vfio for the userspace (kvm guest is kinda
> > >> special and may simply ignore mapping flags in some configs but PPC radix
> > >> guests still rely on this)
> 
> AIUI this isn't for radix, but for DPDK things that we need this.  Ben
> talked about it a bit, but I don't know what the outcome was.

So this is not a powerpc specific issue. Other archs similarily want to
be able to do write combine mappings.

The way sysfs does it is that for prefetchable BARs, it exposes both
a resourceN and a resourceN_wc file.

For VFIO it's a bit more tricky, maybe we need to game the offset using
some of it as flags but that's very fishy, or maybe we do some kind of
ioctl that selects the attributes used for that fd instance for
subsequent mappings...

I'll let Alex chose what he feels most appropriate here.

> > >> 3. what callback and where needs to be added to inform HV/PR KVM about VFIO
> > >> group, like IOMMUMR::add_vfio_group() proposal or something.
> 
> This was discussed, and I'm still thinking about it.  It's kind of
> curly.

  reply	other threads:[~2017-11-14  2:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09  2:50 [RFC PATCH kernel] vfio-pci: Allow write combining Alexey Kardashevskiy
2017-10-10 21:55 ` Alex Williamson
2017-10-11  2:05   ` Alexey Kardashevskiy
2017-10-11  2:42     ` Alex Williamson
2017-10-11  2:56       ` Alexey Kardashevskiy
2017-10-11 15:35         ` Benjamin Herrenschmidt
2017-10-16  5:54           ` Alexey Kardashevskiy
2017-10-16  6:00             ` David Gibson
2017-10-16  7:36               ` Alexey Kardashevskiy
2017-10-16  8:01                 ` David Gibson
2017-11-06  5:44                   ` Alexey Kardashevskiy
2017-11-14  2:23                     ` David Gibson
2017-11-14  2:29                       ` Benjamin Herrenschmidt [this message]
2017-11-14 16:28                         ` Alex Williamson
2017-11-24  4:58                           ` Alexey Kardashevskiy
2017-11-29 18:47                             ` Alex Williamson
2017-11-30  4:20                               ` David Gibson
2017-11-30 20:06                                 ` Benjamin Herrenschmidt
2017-10-16  8:38                 ` Benjamin Herrenschmidt
2017-10-16 11:11                   ` Alexey Kardashevskiy
2017-10-18  7:33                     ` Benjamin Herrenschmidt
2017-10-18  9:00                       ` Alexey Kardashevskiy
2017-10-18 14:21                         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510626542.2397.8.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=eric.auger@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox