Re: [PATCH 0/5] add printk specifier %px, unique identifier

Joe Perches
2017-11-28T17:41:59Z

On Tue, 2017-11-28 at 09:33 -0800, Linus Torvalds wrote:
> On Mon, Nov 27, 2017 at 10:26 PM, Eric W. Biederman
> <ebiederm@xmission.com> wrote:
> > >
> > > Oh well, I just did /proc/<pid>/stack by making it just print 0
> > > unconditionally rather than the hex number.
> >
> > Patch?
>
> Oh, apparently I never pushed out yesterday.
>
> The patch literally just affects the (useless) hex number. So:
>
> cat /proc/self/stack
>
> now prints out
>
> [<0>] proc_pid_stack+0xaa/0x100
> [<0>] proc_single_show+0x48/0x80
> [<0>] seq_read+0xd2/0x410

> I considered getting rid of the whole "[<>]" thing, but that's where
> "maybe there are tools that parse this" came in.
>
> I doubt there are any, though. If proc-ps doesn't look at this, I
> don't know what could. But the format change might as well be a
> separate thing if somebody cares deeply.

Perhaps if there are really tools that parse this
the [<leading-0-width>] should be kept the same too.

>