From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Tobin C. Harding" <me@tobin.cc>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Theodore Ts'o <tytso@mit.edu>, Kees Cook <keescook@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@tycho.ws>,
"Roberts, William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Ian Campbell <ijc@hellion.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <wilal.deacon@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Fries <cfries@google.com>,
Dave Weinstein <olorin@google.com>,
Daniel Micay <danielmicay@gmail.com>,
Djalal Harouni <tixxdz@gmail
Subject: Re: [PATCH 0/5] add printk specifier %px, unique identifier
Date: Tue, 28 Nov 2017 09:41:59 -0800 [thread overview]
Message-ID: <1511890919.19952.42.camel@perches.com> (raw)
In-Reply-To: <CA+55aFx+bMOT-DDp3EYuio0aJDGzWa3PzQxVbM3Rz+GdZKaaFQ@mail.gmail.com>
On Tue, 2017-11-28 at 09:33 -0800, Linus Torvalds wrote:
> On Mon, Nov 27, 2017 at 10:26 PM, Eric W. Biederman
> <ebiederm@xmission.com> wrote:
> > >
> > > Oh well, I just did /proc/<pid>/stack by making it just print 0
> > > unconditionally rather than the hex number.
> >
> > Patch?
>
> Oh, apparently I never pushed out yesterday.
>
> The patch literally just affects the (useless) hex number. So:
>
> cat /proc/self/stack
>
> now prints out
>
> [<0>] proc_pid_stack+0xaa/0x100
> [<0>] proc_single_show+0x48/0x80
> [<0>] seq_read+0xd2/0x410
> I considered getting rid of the whole "[<>]" thing, but that's where
> "maybe there are tools that parse this" came in.
>
> I doubt there are any, though. If proc-ps doesn't look at this, I
> don't know what could. But the format change might as well be a
> separate thing if somebody cares deeply.
Perhaps if there are really tools that parse this
the [<leading-0-width>] should be kept the same too.
>
next prev parent reply other threads:[~2017-11-28 17:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 23:40 [PATCH 0/5] add printk specifier %px, unique identifier Tobin C. Harding
2017-11-27 23:40 ` [PATCH 1/5] docs: correct documentation for %pK Tobin C. Harding
2017-11-28 0:46 ` Kees Cook
2017-11-27 23:40 ` [PATCH 2/5] vsprintf: refactor pK code out of pointer() Tobin C. Harding
2017-11-27 23:40 ` [PATCH 3/5] vsprintf: add specifier %px, unique identifier Tobin C. Harding
2017-11-27 23:40 ` [PATCH 4/5] KVM: use %px to print token identifier Tobin C. Harding
2017-11-27 23:40 ` [PATCH 5/5] vfio_pci: " Tobin C. Harding
2017-11-28 0:03 ` [PATCH 0/5] add printk specifier %px, unique identifier Linus Torvalds
2017-11-28 1:09 ` Linus Torvalds
2017-11-28 6:26 ` Eric W. Biederman
2017-11-28 10:12 ` David Laight
2017-11-28 17:33 ` Linus Torvalds
2017-11-28 17:41 ` Joe Perches [this message]
2017-11-28 18:04 ` Linus Torvalds
2017-11-28 18:11 ` Linus Torvalds
2017-11-28 17:44 ` David Laight
2017-11-28 0:57 ` Kees Cook
2017-11-28 1:43 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511890919.19952.42.camel@perches.com \
--to=joe@perches.com \
--cc=Golden_Miller83@protonmail.ch \
--cc=Jason@zx2c4.com \
--cc=catalin.marinas@arm.com \
--cc=cfries@google.com \
--cc=danielmicay@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc@hellion.org.uk \
--cc=keescook@chromium.org \
--cc=me@tobin.cc \
--cc=olorin@google.com \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tixxdz@gmail \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
--cc=tytso@mit.edu \
--cc=wilal.deacon@arm.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox