From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [v3 3/5] KVM: move kvm_get_kvm to kvm_host.h
Date: Mon, 31 Oct 2016 04:33:06 -0400 (EDT)
Message-ID: <1513747012.9629028.1477902786275.JavaMail.zimbra@redhat.com>
References: <1477895706-22824-1-git-send-email-jike.song@intel.com> <1477895706-22824-4-git-send-email-jike.song@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: alex williamson <alex.williamson@redhat.com>,
        guangrong xiao <guangrong.xiao@linux.intel.com>,
        kwankhede@nvidia.com, cjia@nvidia.com,
        kevin tian <kevin.tian@intel.com>, kvm@vger.kernel.org
To: Jike Song <jike.song@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3-phx2.redhat.com ([209.132.183.24]:45079 "EHLO
        mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1762582AbcJaIdK (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 31 Oct 2016 04:33:10 -0400
In-Reply-To: <1477895706-22824-4-git-send-email-jike.song@intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

> So that external users like vfio can call it without introducing
> symbol-level dependency.
> 
> Signed-off-by: Jike Song <jike.song@intel.com>
> ---
>  include/linux/kvm_host.h | 5 ++++-
>  virt/kvm/kvm_main.c      | 6 ------
>  2 files changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 01c0b9c..e1e877af 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -526,7 +526,10 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned
> vcpu_align,
>  		  struct module *module);
>  void kvm_exit(void);
>  
> -void kvm_get_kvm(struct kvm *kvm);
> +static inline void kvm_get_kvm(struct kvm *kvm)
> +{
> +	atomic_inc(&kvm->users_count);
> +}
>  void kvm_put_kvm(struct kvm *kvm);
>  
>  static inline struct kvm_memslots *__kvm_memslots(struct kvm *kvm, int
>  as_id)
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 348d6fd..e25359b 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -740,12 +740,6 @@ static void kvm_destroy_vm(struct kvm *kvm)
>  	mmdrop(mm);
>  }
>  
> -void kvm_get_kvm(struct kvm *kvm)
> -{
> -	atomic_inc(&kvm->users_count);
> -}
> -EXPORT_SYMBOL_GPL(kvm_get_kvm);
> -
>  void kvm_put_kvm(struct kvm *kvm)
>  {
>  	if (atomic_dec_and_test(&kvm->users_count))
> --
> 1.9.1
> 
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>