From: Paolo Bonzini <pbonzini@redhat.com>
To: kvm@vger.kernel.org
Subject: [PATCH kvm-unit-tests] vmx: fixes for MAXPHYADDR requirement
Date: Wed, 17 Jan 2018 19:03:45 +0100 [thread overview]
Message-ID: <1516212225-37393-2-git-send-email-pbonzini@redhat.com> (raw)
The EPT access tests require at least 41 bits of guest physical address
space. This is because the test data needs a separate PML4 entry in the
EPT table. However, many consumer-grade processors have only 36 or
39-bit MAXPHYADDR, and the tests fail there with a page fault due to
reserved bits set in the guest (GVA->GPA) page tables.
Add a test on MAXPHYADDR and skip the tests if they cannot run on the
system under test, and only require 40 bits to lower the requirements.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
x86/vmx_tests.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index e8c97f2..0c3b5a7 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -2609,6 +2609,10 @@ static void ept_access_test_setup(void)
if (setup_ept(false))
test_skip("EPT not supported");
+ /* We use data->gpa = 1 << 39 so that test data has a separate pml4 entry */
+ if (cpuid_maxphyaddr() < 40)
+ test_skip("Test needs MAXPHYADDR >= 40");
+
test_set_guest(ept_access_test_guest);
test_add_teardown(ept_access_test_teardown, NULL);
@@ -2616,7 +2620,7 @@ static void ept_access_test_setup(void)
TEST_ASSERT(data->hva);
data->hpa = virt_to_phys(data->hva);
- data->gpa = 1ul << 40;
+ data->gpa = 1ul << 39;
data->gva = (void *) ALIGN((unsigned long) alloc_vpages(npages * 2),
size);
TEST_ASSERT(!any_present_pages(page_table, data->gva, size));
--
1.8.3.1
next reply other threads:[~2018-01-17 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:03 Paolo Bonzini [this message]
2018-01-25 15:11 ` [PATCH kvm-unit-tests] vmx: fixes for MAXPHYADDR requirement Radim Krčmář
2018-01-25 16:36 ` Paolo Bonzini
2018-01-25 16:45 ` Radim Krčmář
2018-01-25 17:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516212225-37393-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).