From: Chao Gao <chao.gao@intel.com>
To: kvm@vger.kernel.org
Cc: "Chao Gao" <chao.gao@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH] x86/kvm/vmx: Don't halt vcpu when L1 is injecting events to L2
Date: Thu, 8 Feb 2018 13:13:36 +0800 [thread overview]
Message-ID: <1518066816-7197-1-git-send-email-chao.gao@intel.com> (raw)
Although L2 is in halt state, it will be in the active state after
VM entry if the VM entry is vectoring. Halting the vcpu here means
the event won't be injected to L2 and this decision isn't reported
to L1. Thus L0 drops an event that should be injected to L2.
Because virtual interrupt delivery may wake L2 vcpu, if VID is enabled,
do the same thing -- don't halt L2.
Signed-off-by: Chao Gao <chao.gao@intel.com>
---
arch/x86/kvm/vmx.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index bb5b488..e1fe4e4 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -10985,8 +10985,14 @@ static int nested_vmx_run(struct kvm_vcpu *vcpu, bool launch)
if (ret)
return ret;
- if (vmcs12->guest_activity_state == GUEST_ACTIVITY_HLT)
- return kvm_vcpu_halt(vcpu);
+ if (vmcs12->guest_activity_state == GUEST_ACTIVITY_HLT) {
+ u32 intr_info = vmcs_read32(VM_ENTRY_INTR_INFO_FIELD);
+ u32 exec_control = vmcs_read32(SECONDARY_VM_EXEC_CONTROL);
+
+ if (!(intr_info & VECTORING_INFO_VALID_MASK) &&
+ !(exec_control & SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY))
+ return kvm_vcpu_halt(vcpu);
+ }
vmx->nested.nested_run_pending = 1;
--
1.9.1
next reply other threads:[~2018-02-08 5:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 5:13 Chao Gao [this message]
2018-02-08 10:29 ` [PATCH] x86/kvm/vmx: Don't halt vcpu when L1 is injecting events to L2 Paolo Bonzini
2018-02-08 11:20 ` Chao Gao
-- strict thread matches above, loose matches on Subject: below --
2018-02-08 12:09 Liran Alon
2018-02-08 12:04 ` Chao Gao
2018-02-08 13:53 ` Paolo Bonzini
2018-02-10 2:16 Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518066816-7197-1-git-send-email-chao.gao@intel.com \
--to=chao.gao@intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).