From: David Woodhouse <dwmw2@infradead.org>
To: Jim Mattson <jmattson@google.com>, KarimAllah Ahmed <karahmed@amazon.de>
Cc: "kvm list" <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH 1/3] X86/nVMX: Properly set spec_ctrl and pred_cmd before merging MSRs
Date: Sat, 10 Feb 2018 09:07:04 +0000 [thread overview]
Message-ID: <1518253624.3677.276.camel@infradead.org> (raw)
In-Reply-To: <CALMp9eRbEqSu9M0_Z6aKbhXA9q8fKzkPznXm3ubU8Bcv_p2K1g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On Fri, 2018-02-09 at 15:15 -0800, Jim Mattson wrote:
> On Thu, Feb 8, 2018 at 2:53 PM, KarimAllah Ahmed <karahmed@amazon.de> wrote:
> >
> > These two variables should check whether SPEC_CTRL and PRED_CMD are
> > supposed to be passed through to L2 guests or not. While
> > msr_write_intercepted_l01 would return 'true' if it is not passed through.
> >
> > So just invert the result of msr_write_intercepted_l01 to implement the
> > correct semantics.
> >
> > Fixes: 086e7d4118cc ("KVM: VMX: Allow direct access to MSR_IA32_SPEC_CTRL")
> > Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Radim Krčmář <rkrcmar@redhat.com>
> > Cc: kvm@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> Reviewed-by: Jim Mattson <jmattson@google.com>
We should take this (and 2/3 but not 3/3) through tip/x86/pti too,
right?
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
prev parent reply other threads:[~2018-02-10 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 22:53 [PATCH 1/3] X86/nVMX: Properly set spec_ctrl and pred_cmd before merging MSRs KarimAllah Ahmed
2018-02-08 22:53 ` [PATCH 2/3] KVM/nVMX: Set the CPU_BASED_USE_MSR_BITMAPS if we have a valid L02 MSR bitmap KarimAllah Ahmed
2018-02-08 22:53 ` [PATCH 3/3] X86/nVMX: Update the MSR_BITMAP field with the L02 MSR BITMAP KarimAllah Ahmed
2018-02-09 23:26 ` Jim Mattson
2018-02-09 23:41 ` KarimAllah Ahmed
2018-02-09 23:57 ` Jim Mattson
2018-02-10 0:22 ` KarimAllah Ahmed
2018-02-09 23:15 ` [PATCH 1/3] X86/nVMX: Properly set spec_ctrl and pred_cmd before merging MSRs Jim Mattson
2018-02-10 9:07 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518253624.3677.276.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=jmattson@google.com \
--cc=karahmed@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).