From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Shunyong" Subject: Re: [PATCH] vfio-mdev/samples: change RDI interrupt condition Date: Tue, 20 Mar 2018 07:53:02 +0000 Message-ID: <1521532382.3326.5.camel@hxt-semitech.com> References: <1520492887-8021-1-git-send-email-shunyong.yang@hxt-semitech.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "Zheng, Joey" To: "alex.williamson@redhat.com" , "kwankhede@nvidia.com" Return-path: In-Reply-To: Content-Language: en-US Content-ID: <249E22043C8DB740A09610F1D3810DAB@hxt-semitech.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Hi, Alex, Gentle ping. Could you please help to pull this patch? It's a small fix and Kirti has reviewed. Thanks. Shunyong. On Fri, 2018-03-09 at 11:36 +0530, Kirti Wankhede wrote: > Thanks for fixing it. > Patch looks good to me. > +Alex to pull this patch. > > Reviewed by: Kirti Wankhede > > Thanks, > Kirti > > On 3/8/2018 12:38 PM, Shunyong Yang wrote: > > > > When FIFO mode is enabled, the receive data available interrupt > > (UART_IIR_RDI in code) should be triggered when the number of data > > in FIFO is equal or larger than interrupt trigger level. > > > > This patch changes the trigger level check to ensure multiple bytes > > received from upper layer can trigger RDI interrupt correctly. > > > > Cc: Joey Zheng > > Signed-off-by: Shunyong Yang > > --- > >  samples/vfio-mdev/mtty.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c > > index 09f255bdf3ac..7abb79d8313d 100644 > > --- a/samples/vfio-mdev/mtty.c > > +++ b/samples/vfio-mdev/mtty.c > > @@ -534,7 +534,7 @@ static void handle_bar_read(unsigned int index, > > struct mdev_state *mdev_state, > >   > >   /* Interrupt priority 2: Fifo trigger level > > reached */ > >   if ((ier & UART_IER_RDI) && > > -     (mdev_state->s[index].rxtx.count == > > +     (mdev_state->s[index].rxtx.count >= > >         mdev_state->s[index].intr_trigger_level)) > >   *buf |= UART_IIR_RDI; > >   > >