Re: [PATCH v7 08/13] KVM: x86: Add Intel processor trace context for each vcpu

Alexander Shishkin
2018-05-03T11:39:09Z

On Thu, May 03, 2018 at 08:08:38PM +0800, Luwei Kang wrote:
> From: Chao Peng <chao.p.peng@linux.intel.com>
>
> Add a data structure to save Intel Processor Trace context.
> It mainly include the value of Intel PT host/guest MSRs
> and guest CPUID information.

I'd say that code and data should be in the same patch.

> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> Signed-off-by: Luwei Kang <luwei.kang@intel.com>
> ---
> arch/x86/kvm/vmx.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 27cf417..9a5c26d 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -597,6 +597,23 @@ static inline int pi_test_sn(struct pi_desc *pi_desc)
> (unsigned long *)&pi_desc->control);
> }
>
> +struct pt_ctx {
> + u64 ctl;
> + u64 status;
> + u64 output_base;
> + u64 output_mask;
> + u64 cr3_match;
> + u64 addrs[MSR_IA32_RTIT_ADDR_COUNT];
> +};
> +
> +struct pt_desc {
> + u64 ctl_bitmask;
> + u32 range_cnt;
> + u32 caps[PT_CPUID_REGS_NUM * PT_CPUID_LEAVES];
> + struct pt_ctx host;
> + struct pt_ctx guest;
> +};
> +
> struct vcpu_vmx {
> struct kvm_vcpu vcpu;
> unsigned long host_rsp;
> @@ -693,6 +710,8 @@ struct vcpu_vmx {
> */
> u64 msr_ia32_feature_control;
> u64 msr_ia32_feature_control_valid_bits;
> +
> + struct pt_desc pt_desc;
> };
>
> enum segment_cache_field {
> --
> 1.8.3.1
>