Re: [PATCH v2 00/12] KVM/X86: Introduce a new guest mapping interface

Raslan, KarimAllah
2018-05-22T15:43:12Z

On Tue, 2018-05-15 at 12:06 -0400, Konrad Rzeszutek Wilk wrote:
> On Mon, Apr 16, 2018 at 02:27:13PM +0200, Paolo Bonzini wrote:
> >
> > On 16/04/2018 14:09, Raslan, KarimAllah wrote:
> > >
> > > >
> > > > I assume the caching will also be a separate patch.
> > > Yup, do you want me to include it in this one? I already have it, I
> > > just thought that I get those bits out first.
> >
> > It's the same for me.
> >
> > Paolo
> >
> > >
> > > >
> > > > It looks good except that I'd squash patches 4 and 9 together.
> > > Yup, makes sense. I should have squashed them when I removed the
> > > lifecycle change!
> > >
> > > Thanks for the review :)
> > >
> > > >
> > > > But I'd like a second set of eyes to look at it.
>
> Did anybody else end up reviewing these patches? And would it make sense
> to repost a new version with the #4 and #9 squashed? Thanks.

No, no second review yet. I will squash and repost a new version.

>
> >
> >
>
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B