Re: [PATCH v2 00/12] KVM/X86: Introduce a new guest mapping interface

Raslan, KarimAllah
2018-07-10T12:06:33Z

On Mon, 2018-04-16 at 13:10 +0200, Paolo Bonzini wrote:
> On 15/04/2018 23:53, KarimAllah Ahmed wrote:
> >
> > Guest memory can either be directly managed by the kernel (i.e. have a "struct
> > page") or they can simply live outside kernel control (i.e. do not have a
> > "struct page"). KVM mostly support these two modes, except in a few places
> > where the code seems to assume that guest memory must have a "struct page".
> >
> > This patchset introduces a new mapping interface to map guest memory into host
> > kernel memory which also supports PFN-based memory (i.e. memory without 'struct
> > page'). It also converts all offending code to this interface or simply
> > read/write directly from guest memory.
> >
> > As far as I can see all offending code is now fixed except the APIC-access page
> > which I will handle in a seperate patch.
>
> I assume the caching will also be a separate patch.
>
> It looks good except that I'd squash patches 4 and 9 together. But I'd
> like a second set of eyes to look at it.

BTW, Why did you want to squash these 2 patches specifically? They are
very unrelated to me. The only common thing is that they switch from
code that supports only "struct page" to code that supports PFN only
but this is also common for all other patches.

>
> Thanks,
>
> Paolo
>
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B