Re: [PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

David Miller
2018-06-10T19:27:52Z

From: Jason Wang <jasowang@redhat.com>
Date: Fri, 8 Jun 2018 11:50:42 +0800

> This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if
> a userpsace want to enable VRITIO_F_ANY_LAYOUT,
> VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will
> break networking. Fixing this by safely removing
> VHOST_NET_F_VIRTIO_NET_HDR support. There should be very few or even
> no userspace can use this. Further cleanups could be done for
> -net-next for safety.
>
> In the future, we need a vhost dedicated feature set/get ioctl()
> instead of reusing virtio ones.
>
> Fixes: 4e9fa50c6ccbe ("vhost: move features to core")
> Signed-off-by: Jason Wang <jasowang@redhat.com>

I don't see this discussion as resolved yet so I'll mark this
as Deferred in patchwork.

Thanks.