From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Qiang Subject: [PATCH] vfio: fix potential memory leak in vfio_msi_cap_len Date: Mon, 27 Aug 2018 05:47:21 -0700 Message-ID: <1535374041-3551-1-git-send-email-liq3ea@gmail.com> Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, liqiang02@corp.netease.com, Li Qiang To: alex.williamson@redhat.com, eric.auger@redhat.com Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Free the vdev->msi_perm in error path. Signed-off-by: Li Qiang --- drivers/vfio/pci/vfio_pci_config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c index 115a36f6f403..62023b4a373b 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c @@ -1180,8 +1180,10 @@ static int vfio_msi_cap_len(struct vfio_pci_device *vdev, u8 pos) return -ENOMEM; ret = init_pci_cap_msi_perm(vdev->msi_perm, len, flags); - if (ret) + if (ret) { + kfree(vdev->msi_perm); return ret; + } return len; } -- 2.11.0