From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Subject: Re: [PATCH v6 4/5] x86/kvm: use __decrypted attribute in shared variables Date: Mon, 10 Sep 2018 06:15:10 -0700 Message-ID: <1536585310.11460.34.camel@intel.com> References: <1536343050-18532-1-git-send-email-brijesh.singh@amd.com> <1536343050-18532-5-git-send-email-brijesh.singh@amd.com> <20180910120416.GD21815@zn.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Thomas Gleixner , "H. Peter Anvin" , Paolo Bonzini , Radim =?UTF-8?Q?Kr=C4=8Dm=C3=A1=C5=99?= To: Borislav Petkov , Brijesh Singh Return-path: In-Reply-To: <20180910120416.GD21815@zn.tnic> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, 2018-09-10 at 14:04 +0200, Borislav Petkov wrote: > On Fri, Sep 07, 2018 at 12:57:29PM -0500, Brijesh Singh wrote: > > > > Commit: 368a540e0232 (x86/kvmclock: Remove memblock dependency) > > caused SEV guest regression. > When mentioning a commit in the commit message, put it on a separate > line, like this: > > "Commit > >   368a540e0232 (x86/kvmclock: Remove memblock dependency) > > caused a SEV guest regression." Heh, that was the original formatting until I asked him to change it: https://lkml.org/lkml/2018/8/29/809.  Checkpatch throws an error if there's a newline after 'Commit'.  Though looking at this again, there shouldn't be a colon after 'Commit' and there should be quotes inside the parentheses, e.g. this satisfies checkpatch: Commit 368a540e0232 ("x86/kvmclock: Remove memblock dependency")