From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Raslan, KarimAllah" Subject: Re: [PATCH v3 06/13] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap Date: Mon, 22 Oct 2018 21:49:56 +0000 Message-ID: <1540244996.11839.46.camel@amazon.de> References: <1540074145-31285-1-git-send-email-karahmed@amazon.de> <1540074145-31285-7-git-send-email-karahmed@amazon.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "rkrcmar@redhat.com" , "pbonzini@redhat.com" To: "jmattson@google.com" Return-path: In-Reply-To: Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org T24gTW9uLCAyMDE4LTEwLTIyIGF0IDE0OjQyIC0wNzAwLCBKaW0gTWF0dHNvbiB3cm90ZToNCj4g T24gU2F0LCBPY3QgMjAsIDIwMTggYXQgMzoyMiBQTSwgS2FyaW1BbGxhaCBBaG1lZCA8a2FyYWht ZWRAYW1hem9uLmRlPiB3cm90ZToNCj4gPiANCj4gPiBVc2Uga3ZtX3ZjcHVfbWFwIHdoZW4gbWFw cGluZyB0aGUgTDEgTVNSIGJpdG1hcCBzaW5jZSB1c2luZw0KPiA+IGt2bV92Y3B1X2dwYV90b19w YWdlKCkgYW5kIGttYXAoKSB3aWxsIG9ubHkgd29yayBmb3IgZ3Vlc3QgbWVtb3J5IHRoYXQgaGFz DQo+ID4gYSAic3RydWN0IHBhZ2UiLg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IEthcmltQWxs YWggQWhtZWQgPGthcmFobWVkQGFtYXpvbi5kZT4NCj4gPiAtLS0NCj4gPiB2MSAtPiB2MjoNCj4g PiAtIERvIG5vdCBjaGFuZ2UgdGhlIGxpZmVjeWNsZSBvZiB0aGUgbWFwcGluZyAocGJvbnppbmkp DQo+ID4gLS0tDQo+ID4gIGFyY2gveDg2L2t2bS92bXguYyB8IDE0ICsrKysrKysrLS0tLS0tDQo+ ID4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pDQo+ID4g DQo+ID4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2t2bS92bXguYyBiL2FyY2gveDg2L2t2bS92bXgu Yw0KPiA+IGluZGV4IGQ4NTc0MDEuLjViMTVjYTIgMTAwNjQ0DQo+ID4gLS0tIGEvYXJjaC94ODYv a3ZtL3ZteC5jDQo+ID4gKysrIGIvYXJjaC94ODYva3ZtL3ZteC5jDQo+ID4gQEAgLTg0Nyw2ICs4 NDcsOSBAQCBzdHJ1Y3QgbmVzdGVkX3ZteCB7DQo+ID4gICAgICAgICBzdHJ1Y3QgcGFnZSAqYXBp Y19hY2Nlc3NfcGFnZTsNCj4gPiAgICAgICAgIHN0cnVjdCBwYWdlICp2aXJ0dWFsX2FwaWNfcGFn ZTsNCj4gPiAgICAgICAgIHN0cnVjdCBwYWdlICpwaV9kZXNjX3BhZ2U7DQo+ID4gKw0KPiA+ICsg ICAgICAgc3RydWN0IGt2bV9ob3N0X21hcCBtc3JfYml0bWFwX21hcDsNCj4gPiArDQo+ID4gICAg ICAgICBzdHJ1Y3QgcGlfZGVzYyAqcGlfZGVzYzsNCj4gPiAgICAgICAgIGJvb2wgcGlfcGVuZGlu ZzsNCj4gPiAgICAgICAgIHUxNiBwb3N0ZWRfaW50cl9udjsNCj4gPiBAQCAtMTE1NDYsOSArMTE1 NDksMTAgQEAgc3RhdGljIGlubGluZSBib29sIG5lc3RlZF92bXhfcHJlcGFyZV9tc3JfYml0bWFw KHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHZtY3MxMiAqdm1jczEyKQ0KPiA+ICB7DQo+ID4g ICAgICAgICBpbnQgbXNyOw0KPiA+IC0gICAgICAgc3RydWN0IHBhZ2UgKnBhZ2U7DQo+ID4gICAg ICAgICB1bnNpZ25lZCBsb25nICptc3JfYml0bWFwX2wxOw0KPiA+ICAgICAgICAgdW5zaWduZWQg bG9uZyAqbXNyX2JpdG1hcF9sMCA9IHRvX3ZteCh2Y3B1KS0+bmVzdGVkLnZtY3MwMi5tc3JfYml0 bWFwOw0KPiA+ICsgICAgICAgc3RydWN0IGt2bV9ob3N0X21hcCAqbWFwID0gJnRvX3ZteCh2Y3B1 KS0+bmVzdGVkLm1zcl9iaXRtYXBfbWFwOw0KPiA+ICsNCj4gPiAgICAgICAgIC8qDQo+ID4gICAg ICAgICAgKiBwcmVkX2NtZCAmIHNwZWNfY3RybCBhcmUgdHJ5aW5nIHRvIHZlcmlmeSB0d28gdGhp bmdzOg0KPiA+ICAgICAgICAgICoNCj4gPiBAQCAtMTE1NzQsMTEgKzExNTc4LDEwIEBAIHN0YXRp YyBpbmxpbmUgYm9vbCBuZXN0ZWRfdm14X3ByZXBhcmVfbXNyX2JpdG1hcChzdHJ1Y3Qga3ZtX3Zj cHUgKnZjcHUsDQo+ID4gICAgICAgICAgICAgIXByZWRfY21kICYmICFzcGVjX2N0cmwpDQo+ID4g ICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPiANCj4gPiAtICAgICAgIHBhZ2UgPSBr dm1fdmNwdV9ncGFfdG9fcGFnZSh2Y3B1LCB2bWNzMTItPm1zcl9iaXRtYXApOw0KPiA+IC0gICAg ICAgaWYgKGlzX2Vycm9yX3BhZ2UocGFnZSkpDQo+ID4gKyAgICAgICBpZiAoa3ZtX3ZjcHVfbWFw KHZjcHUsIGdwYV90b19nZm4odm1jczEyLT5tc3JfYml0bWFwKSwgbWFwKSkNCj4gDQo+IElzbid0 IHRoaXMgdGhlIHNvcnQgb2YgaGlnaCBmcmVxdWVuY3kgb3BlcmF0aW9uIHRoYXQgc2hvdWxkIG5v dCB1c2UgdGhlIG5ldyBBUEk/DQoNCldpdGggdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gb2Yg dGhlIEFQSSwgeWVzLiBUaGUgcGVyZm9ybWFuY2Ugd2lsbCBiZcKgDQpob3JyaWJsZS4gVGhpcyBk b2VzIG5vdCBhZmZlY3QgdGhlIGN1cnJlbnQgdXNlcnMgdGhvdWdoIChpLmUuIHdoZW4gZ3Vlc3Qg bWVtb3J5wqANCmlzIGJhY2tlZCBieSAic3RydWN0IHBhZ2UiKS4NCg0KSSBoYXZlIGEgZmV3IHBh dGNoZXMgdGhhdCBpbXBsZW1lbnRzIGEgcGZuX2NhY2hlIG9uIHRvcCBvZiB0aGlzIGFzIHN1Z2dl c3RlZCBiecKgDQpQYW9sby4gVGhpcyB3b3VsZCBhbGxvdyB0aGlzIEFQSSB0byBiZSB1c2VkIGZv ciB0aGlzIHR5cGUgb2YgaGlnaC1mcmVxdWVuY3nCoA0KbWFwcGluZ3MuDQoNCkZvciBleGFtcGxl IHdpdGggdGhpcyBwZm5fY2FjaGUsIGJvb3RpbmcgYW4gVWJ1bnR1IHdhcyAxMHggZmFzdGVyIChm cm9tIH4gMsKgDQptaW51dGVzIHRvIDEzIHNlY29uZHMpLg0KDQo+IA0KPiA+IA0KPiA+ICAgICAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7DQo+ID4gDQo+ID4gLSAgICAgICBtc3JfYml0bWFwX2wx ID0gKHVuc2lnbmVkIGxvbmcgKilrbWFwKHBhZ2UpOw0KPiA+ICsgICAgICAgbXNyX2JpdG1hcF9s MSA9ICh1bnNpZ25lZCBsb25nICopbWFwLT5odmE7DQo+ID4gICAgICAgICBpZiAobmVzdGVkX2Nw dV9oYXNfYXBpY19yZWdfdmlydCh2bWNzMTIpKSB7DQo+ID4gICAgICAgICAgICAgICAgIC8qDQo+ ID4gICAgICAgICAgICAgICAgICAqIEwwIG5lZWQgbm90IGludGVyY2VwdCByZWFkcyBmb3IgTVNS cyBiZXR3ZWVuIDB4ODAwIGFuZCAweDhmZiwgaXQNCj4gPiBAQCAtMTE2MjYsOCArMTE2MjksNyBA QCBzdGF0aWMgaW5saW5lIGJvb2wgbmVzdGVkX3ZteF9wcmVwYXJlX21zcl9iaXRtYXAoc3RydWN0 IGt2bV92Y3B1ICp2Y3B1LA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBNU1JfSUEzMl9QUkVEX0NNRCwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgTVNSX1RZUEVfVyk7DQo+ID4gDQo+ID4gLSAgICAgICBrdW5tYXAocGFnZSk7 DQo+ID4gLSAgICAgICBrdm1fcmVsZWFzZV9wYWdlX2NsZWFuKHBhZ2UpOw0KPiA+ICsgICAgICAg a3ZtX3ZjcHVfdW5tYXAoJnRvX3ZteCh2Y3B1KS0+bmVzdGVkLm1zcl9iaXRtYXBfbWFwKTsNCj4g PiANCj4gPiAgICAgICAgIHJldHVybiB0cnVlOw0KPiA+ICB9DQo+ID4gLS0NCj4gPiAyLjcuNA0K PiA+IA0KPiANCkFtYXpvbiBEZXZlbG9wbWVudCBDZW50ZXIgR2VybWFueSBHbWJICkJlcmxpbiAt IERyZXNkZW4gLSBBYWNoZW4KbWFpbiBvZmZpY2U6IEtyYXVzZW5zdHIuIDM4LCAxMDExNyBCZXJs aW4KR2VzY2hhZWZ0c2Z1ZWhyZXI6IERyLiBSYWxmIEhlcmJyaWNoLCBDaHJpc3RpYW4gU2NobGFl Z2VyClVzdC1JRDogREUyODkyMzc4NzkKRWluZ2V0cmFnZW4gYW0gQW10c2dlcmljaHQgQ2hhcmxv dHRlbmJ1cmcgSFJCIDE0OTE3MyBCCg==