From: Julien Thierry <julien.thierry@arm.com>
To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Cc: Sami Mujawar <sami.mujawar@arm.com>, will.deacon@arm.com
Subject: [PATCH kvmtool 1/6] rtc: Initialize the Register D for MC146818 RTC
Date: Tue, 4 Dec 2018 11:14:28 +0000 [thread overview]
Message-ID: <1543922073-55530-2-git-send-email-julien.thierry@arm.com> (raw)
In-Reply-To: <1543922073-55530-1-git-send-email-julien.thierry@arm.com>
From: Sami Mujawar <sami.mujawar@arm.com>
Some software drivers check the VRT bit (BIT7) of Register D before
using the MC146818 RTC. Initialized the VRT bit in rtc__init() to
indicate that the RAM and time contents are valid.
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Julien Thierry <julien.thierry@arm.com>
---
hw/rtc.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/rtc.c b/hw/rtc.c
index 0649b5d..c1fa72f 100644
--- a/hw/rtc.c
+++ b/hw/rtc.c
@@ -25,6 +25,11 @@
#define RTC_REG_C 0x0C
#define RTC_REG_D 0x0D
+/*
+ * Register D Bits
+ */
+#define RTC_REG_D_VRT (1 << 7)
+
struct rtc_device {
u8 cmos_idx;
u8 cmos_data[128];
@@ -140,6 +145,9 @@ int rtc__init(struct kvm *kvm)
return r;
}
+ /* Set the VRT bit in Register D to indicate valid RAM and time */
+ rtc.cmos_data[RTC_REG_D] = RTC_REG_D_VRT;
+
return r;
}
dev_init(rtc__init);
--
1.9.1
next prev parent reply other threads:[~2018-12-04 11:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 11:14 [PATCH kvmtool 0/6] arm: Add support for firmware booting Julien Thierry
2018-12-04 11:14 ` Julien Thierry [this message]
2018-12-12 18:16 ` [PATCH kvmtool 1/6] rtc: Initialize the Register D for MC146818 RTC Andre Przywara
2018-12-14 18:58 ` Sami Mujawar
2018-12-04 11:14 ` [PATCH kvmtool 2/6] arm: Move firmware function Julien Thierry
2018-12-12 18:16 ` Andre Przywara
2018-12-04 11:14 ` [PATCH kvmtool 3/6] builtin-run: Do not look for default kernel when firmware is provided Julien Thierry
2018-12-12 18:16 ` Andre Przywara
2018-12-04 11:14 ` [PATCH kvmtool 4/6] arm: Support firmware loading Julien Thierry
2018-12-14 18:08 ` Andre Przywara
2018-12-17 10:05 ` Julien Thierry
2018-12-17 12:01 ` André Przywara
2018-12-04 11:14 ` [PATCH kvmtool 5/6] kvm: Add arch specific reset Julien Thierry
2018-12-14 18:11 ` Andre Przywara
2018-12-17 10:25 ` Julien Thierry
2018-12-04 11:14 ` [PATCH kvmtool 6/6] arm: Support non-volatile memory Julien Thierry
2018-12-14 18:09 ` Andre Przywara
2018-12-17 10:31 ` Julien Thierry
2018-12-17 12:04 ` André Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543922073-55530-2-git-send-email-julien.thierry@arm.com \
--to=julien.thierry@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=sami.mujawar@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox