From: Wei Wang <wei.w.wang@intel.com>
To: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
mst@redhat.com, cohuck@redhat.com
Cc: pasic@linux.ibm.com, dgilbert@redhat.com, pbonzini@redhat.com
Subject: [PATCH v1 2/2] virtio-balloon: improve update_balloon_size_func
Date: Thu, 3 Jan 2019 13:31:02 +0800 [thread overview]
Message-ID: <1546493462-32244-3-git-send-email-wei.w.wang@intel.com> (raw)
In-Reply-To: <1546493462-32244-1-git-send-email-wei.w.wang@intel.com>
There is no need to update the balloon actual register when there is no
ballooning request. This patch avoids update_balloon_size when diff is 0.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
---
drivers/virtio/virtio_balloon.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 9a82a11..4884b85 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -435,9 +435,12 @@ static void update_balloon_size_func(struct work_struct *work)
update_balloon_size_work);
diff = towards_target(vb);
+ if (!diff)
+ return;
+
if (diff > 0)
diff -= fill_balloon(vb, diff);
- else if (diff < 0)
+ else
diff += leak_balloon(vb, -diff);
update_balloon_size(vb);
--
2.7.4
next prev parent reply other threads:[~2019-01-03 5:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 5:31 [PATCH v1 0/2] virtio-balloon: tweak config_changed Wei Wang
2019-01-03 5:31 ` [PATCH v1 1/2] virtio-balloon: tweak config_changed implementation Wei Wang
2019-01-03 9:40 ` Cornelia Huck
2019-01-03 10:31 ` Wei Wang
2019-01-03 12:16 ` Halil Pasic
2019-01-03 16:42 ` Michael S. Tsirkin
2019-01-04 5:14 ` Wei Wang
2019-01-03 5:31 ` Wei Wang [this message]
2019-01-03 9:42 ` [PATCH v1 2/2] virtio-balloon: improve update_balloon_size_func Cornelia Huck
2019-01-03 12:18 ` Halil Pasic
2019-01-03 9:26 ` [PATCH v1 0/2] virtio-balloon: tweak config_changed Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546493462-32244-3-git-send-email-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox