From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A3B5C10F11 for ; Wed, 24 Apr 2019 20:51:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E546B2183E for ; Wed, 24 Apr 2019 20:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732819AbfDXUvI (ORCPT ); Wed, 24 Apr 2019 16:51:08 -0400 Received: from mga06.intel.com ([134.134.136.31]:39407 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731341AbfDXUvH (ORCPT ); Wed, 24 Apr 2019 16:51:07 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 13:51:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,390,1549958400"; d="scan'208";a="134095107" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga007.jf.intel.com with ESMTP; 24 Apr 2019 13:51:04 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.40]) by PGSMSX108.gar.corp.intel.com ([169.254.8.246]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 04:51:03 +0800 From: "Huang, Kai" To: "Christopherson, Sean J" CC: "kvm@vger.kernel.org" , "tglx@linutronix.de" , "guangrong.xiao@gmail.com" , "hpa@zytor.com" , "pbonzini@redhat.com" , "bp@alien8.de" , "thomas.lendacky@amd.com" , "rkrcmar@redhat.com" , "brijesh.singh@amd.com" , "junaids@google.com" Subject: Re: [PATCH] kvm: x86: Fix several SPTE mask calculation errors caused by MKTME Thread-Topic: [PATCH] kvm: x86: Fix several SPTE mask calculation errors caused by MKTME Thread-Index: AQHU9DW//hMP+P/kLkeZpj3T4GKBXaZH5WGAgACbvQCAAj6DgIAAPssAgABR5AA= Date: Wed, 24 Apr 2019 20:51:03 +0000 Message-ID: <1556139060.29618.34.camel@intel.com> References: <20190416091948.4420-1-kai.huang@linux.intel.com> <20190422163929.GB1236@linux.intel.com> <1555984614.2776.58.camel@intel.com> <1556107989.29618.30.camel@intel.com> <20190424155754.GD18442@linux.intel.com> In-Reply-To: <20190424155754.GD18442@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.88.189] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org T24gV2VkLCAyMDE5LTA0LTI0IGF0IDA4OjU3IC0wNzAwLCBTZWFuIENocmlzdG9waGVyc29uIHdy b3RlOg0KPiBPbiBXZWQsIEFwciAyNCwgMjAxOSBhdCAwNToxMzoxMkFNIC0wNzAwLCBIdWFuZywg S2FpIHdyb3RlOg0KPiA+IA0KPiA+ID4gPiA+ICAJbG93X3BoeXNfYml0cyA9IGJvb3RfY3B1X2Rh dGEueDg2X3BoeXNfYml0czsNCj4gPiA+ID4gPiAtCWlmIChib290X2NwdV9kYXRhLng4Nl9waHlz X2JpdHMgPA0KPiA+ID4gPiA+IC0JICAgIDUyIC0gc2hhZG93X25vbnByZXNlbnRfb3JfcnN2ZF9t YXNrX2xlbikgew0KPiA+ID4gPiA+ICsJc2hhZG93X25vbnByZXNlbnRfb3JfcnN2ZF9tYXNrID0g MDsNCj4gPiA+ID4gPiArCWlmIChuZWVkX2wxdGYpIHsNCj4gPiA+ID4gPiAgCQlzaGFkb3dfbm9u cHJlc2VudF9vcl9yc3ZkX21hc2sgPQ0KPiA+ID4gPiA+ICAJCQlyc3ZkX2JpdHMoYm9vdF9jcHVf ZGF0YS54ODZfcGh5c19iaXRzIC0NCj4gPiA+ID4gPiAgCQkJCSAgc2hhZG93X25vbnByZXNlbnRf b3JfcnN2ZF9tYXNrX2xlbiwNCj4gPiA+ID4gDQo+ID4gPiA+IFRoaXMgaXMgYnJva2VuLCB0aGUg cmVzZXJ2ZWQgYml0cyBtYXNrIGlzIGJlaW5nIGNhbGN1bGF0ZWQgd2l0aCB0aGUgd3JvbmcNCj4g PiA+ID4gbnVtYmVyIG9mIHBoeXNpY2FsIGJpdHMuICBJIHRoaW5rIGZpeGluZyB0aGlzIHdvdWxk IGVsaW1pbmF0ZSB0aGUgbmVlZCBmb3INCj4gPiA+ID4gdGhlIGhpZ2hfZ3BhX29mZnNldCBzaGVu YW5pZ2Fucy4NCj4gPiA+IA0KPiA+ID4gWW91IGFyZSByaWdodC4gc2hvdWxkIHVzZSAnc2hhZG93 X3BoeXNfYml0cycgaW5zdGVhZC4gVGhhbmtzLiBMZXQgbWUgdGhpbmsNCj4gPiA+IHdoZXRoZXIg aGlnaF9ncGFfb2Zmc2V0IGNhbiBiZSBhdm9pZGVkLg0KPiA+ID4gDQo+ID4gDQo+ID4gSGkgU2Vh biwgUGFvbG8sIGFuZCBvdGhlcnMsDQo+ID4gDQo+ID4gQWZ0ZXIgcmUtdGhpbmtpbmcsIEkgdGhp bmsgd2Ugc2hvdWxkIGV2ZW4gdXNlIGJvb3RfY3B1X2RhdGEueDg2X2NhY2hlX2JpdHMgdG8NCj4g PiBjYWxjdWxhdGUgc2hhZG93X25vbnByZXNlbnRfb3JfcnN2ZF9tYXNrLCBidXQgbm90IHNoYWRv d19waHlzX2JpdHMsIHNpbmNlIGZvcg0KPiA+IHNvbWUgcGFydGljdWxhciBJbnRlbCBDUFUsIHRo ZSBpbnRlcm5hbCBjYWNoZSBiaXRzIGFyZSBsYXJnZXIgdGhhbiBwaHlzaWNhbA0KPiA+IGFkZHJl c3MgYml0cyByZXBvcnRlZCBieSBDUFVJRC4gVG8gbWFrZSB0aGlzIEtWTSBMMVRGIG1pZ2l0YXRp b24gd29yaywgd2UNCj4gPiBhY3R1YWxseSBoYXZlIHRvIHNldCB0aGUgaGlnaGVzdCBiaXQgb2Yg Y2FjaGUgYml0cywgYnV0IG5vdCB0aGUgcGh5c2ljYWwNCj4gPiBhZGRyZXNzIGJpdHMgaW4gU1BU RSAod2hpY2ggbWVhbnMgdGhlIG9yaWdpbmFsIGNvZGUgYWxzbyBoYXMgYSBidWcgaWYgSQ0KPiA+ IHVuZGVyc3RhbmQgY29ycmVjdGx5KS4NCj4gDQo+IFdoYXQncyB0aGUgZXhhY3QgQ1BVIGJlaGF2 aW9yIHlvdSdyZSByZWZlcmVuY2luZz8gIFVubGVzcyBpdCdzIGRvaW5nIHNvbWUNCj4gY3Jhenkg UEEgYWxpYXNpbmcgaXQgc2hvdWxkIGJlIGEgbm9uLWlzc3VlLg0KDQpUaGVyZSdzIG5vIHNwZWMg c2F5aW5nIHRoZSBleGFjdCBiZWhhdmlvciwgYnV0IEkgYW0gbG9va2luZyBhdCB0aGlzOg0KDQpo dHRwczovL3NvZnR3YXJlLmludGVsLmNvbS9zZWN1cml0eS1zb2Z0d2FyZS1ndWlkYW5jZS9pbnNp Z2h0cy9kZWVwLWRpdmUtaW50ZWwtYW5hbHlzaXMtbDEtdGVybWluYWwtDQpmYXVsdA0KDQoJIlNv bWUgcHJvY2Vzc29ycyBtYXkgaW50ZXJuYWxseSBpbXBsZW1lbnQgbW9yZSBhZGRyZXNzIGJpdHMg aW4gdGhlIEwxRCBjYWNoZSB0aGFuIGFyZQ0KICAgICAgICAgcmVwb3J0ZWQgaW4gTUFYUEhZQURE Ui4gVGhpcyBpcyBub3QgcmVwb3J0ZWQgYnkgQ1BVSUQsIHNvIHRoZSBmb2xsb3dpbmcgdGFibGUg Y2FuIGJlIHVzZWQ6DQoNCglUYWJsZSAyOiBQcm9jZXNzb3JzIEltcGxlbWVudGluZyBNb3JlIEwx RCBBZGRyZXNzIEJpdHMgdGhhbiBSZXBvcnRlZA0KCVByb2Nlc3NvciBjb2RlIG5hbWUJSW1wbGVt ZW50ZWQgTDFEIGJpdHMNCglOZWhhbGVtLCBXZXN0bWVyZQk0NA0KCVNhbmR5IEJyaWRnZSBhbmQg bmV3ZXIJNDYNCglPbiB0aGVzZSBzeXN0ZW1zIHRoZSBPUyBjYW4gc2V0IG9uZSBvciBtb3JlIGJp dHMgYWJvdmUgTUFYUEhZQUREUiBidXQgYmVsb3cgdGhlIEwxRCBsaW1pdCANCgl0byBlbnN1cmUg dGhhdCB0aGUgUFRFIGRvZXMgbm90IHJlZmVyZW5jZSBhbnkgcGh5c2ljYWwgbWVtb3J5IGFkZHJl c3MuIFRoaXMgY2FuIG9mdGVuIGJlIA0KCXVzZWQgdG8gYXZvaWQgbGltaXRpbmcgdGhlIGFtb3Vu dCBvZiB1c2FibGUgcGh5c2ljYWwgbWVtb3J5LiINCg0KQW5kIGtlcm5lbCBhY3R1YWxseSBzZXQg bGltaXQgb2YgdXNhYmxlIHBoeXNpY2FsIG1lbW9yeSBieSBjaGVja2luZyBib290X2NwdV9kYXRh Lng4Nl9jYWNoZV9iaXRzOg0KDQpzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGxvbmcgbG9uZyBsMXRm X3Bmbl9saW1pdCh2b2lkKQ0Kew0KICAgICAgICByZXR1cm4gQklUX1VMTChib290X2NwdV9kYXRh Lng4Nl9jYWNoZV9iaXRzIC0gMSAtIFBBR0VfU0hJRlQpOw0KfQ0KDQpUaGFua3MsDQotS2Fp