Re: [PATCH v2 1/2] KVM: Start populating /sys/hypervisor with KVM entries

Alexander Graf
2019-05-16T13:50:32Z

On 14.05.19 08:16, Filippo Sironi wrote:
> Start populating /sys/hypervisor with KVM entries when we're running on
> KVM. This is to replicate functionality that's available when we're
> running on Xen.
>
> Start with /sys/hypervisor/uuid, which users prefer over
> /sys/devices/virtual/dmi/id/product_uuid as a way to recognize a virtual
> machine, since it's also available when running on Xen HVM and on Xen PV
> and, on top of that doesn't require root privileges by default.
> Let's create arch-specific hooks so that different architectures can
> provide different implementations.
>
> Signed-off-by: Filippo Sironi <sironi@amazon.de>

I think this needs something akin to

https://www.kernel.org/doc/Documentation/ABI/stable/sysfs-hypervisor-xen

to document which files are available.

> ---
> v2:
> * move the retrieval of the VM UUID out of uuid_show and into
> kvm_para_get_uuid, which is a weak function that can be overwritten
>
> drivers/Kconfig | 2 ++
> drivers/Makefile | 2 ++
> drivers/kvm/Kconfig | 14 ++++++++++++++
> drivers/kvm/Makefile | 1 +
> drivers/kvm/sys-hypervisor.c | 30 ++++++++++++++++++++++++++++++
> 5 files changed, 49 insertions(+)
> create mode 100644 drivers/kvm/Kconfig
> create mode 100644 drivers/kvm/Makefile
> create mode 100644 drivers/kvm/sys-hypervisor.c
>

[...]

> +
> +__weak const char *kvm_para_get_uuid(void)
> +{
> + return NULL;
> +}
> +
> +static ssize_t uuid_show(struct kobject *obj,
> + struct kobj_attribute *attr,
> + char *buf)
> +{
> + const char *uuid = kvm_para_get_uuid();
> + return sprintf(buf, "%s\n", uuid);

The usual return value for the Xen /sys/hypervisor interface is
"<denied>". Wouldn't it make sense to follow that pattern for the KVM
one too? Currently, if we can not determine the UUID this will just
return (null).

Otherwise, looks good to me. Are you aware of any other files we should
provide? Also, is there any reason not to implement ARM as well while at it?

Alex

> +}
> +
> +static struct kobj_attribute uuid = __ATTR_RO(uuid);
> +
> +static int __init uuid_init(void)
> +{
> + if (!kvm_para_available())
> + return 0;
> + return sysfs_create_file(hypervisor_kobj, &uuid.attr);
> +}
> +
> +device_initcall(uuid_init);
>