Re: [PATCH v14 03/11] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

[Pierre Morel <pmorel@linux.ibm.com>]

On 1/11/23 18:14, Nina Schoetterl-Glausch wrote:
> On Tue, 2023-01-10 at 15:29 +0100, Thomas Huth wrote:
>> On 05/01/2023 15.53, Pierre Morel wrote:
>>> On interception of STSI(15.1.x) the System Information Block
>>> (SYSIB) is built from the list of pre-ordered topology entries.
>>>
>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>> ---
>>
> [...]
> 
>>> +void insert_stsi_15_1_x(S390CPU *cpu, int sel2, __u64 addr, uint8_t ar)
>>> +{
>>> +    union {
>>> +        char place_holder[S390_TOPOLOGY_SYSIB_SIZE];
>>> +        SysIB_151x sysib;
>>> +    } buffer QEMU_ALIGNED(8) = {};
>>> +    int len;
>>> +
>>> +    if (!s390_has_topology() || sel2 < 2 || sel2 > SCLP_READ_SCP_INFO_MNEST) {
>>> +        setcc(cpu, 3);
>>> +        return;
>>> +    }
>>> +
>>> +    len = setup_stsi(cpu, &buffer.sysib, sel2);
>>> +
>>> +    if (len > 4096) {
>>
>> Maybe use TARGET_PAGE_SIZE instead of 4096 ?
> 
> sizeof(SysIB) would be preferable IMO.

Yes better


Thanks,

Regards,
Pierre

-- 
Pierre Morel
IBM Lab Boeblingen