From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, thuth@redhat.com, david@redhat.com,
borntraeger@de.ibm.com, frankja@linux.ibm.com
Subject: [kvm-unit-tests PATCH v1 4/5] s390x: sclp: add service call instruction wrapper
Date: Tue, 22 Oct 2019 12:53:03 +0200 [thread overview]
Message-ID: <1571741584-17621-5-git-send-email-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <1571741584-17621-1-git-send-email-imbrenda@linux.ibm.com>
Add a wrapper for the service call instruction, and use it for SCLP
interactions instead of using inline assembly everywhere.
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
lib/s390x/asm/arch_def.h | 13 +++++++++++++
lib/s390x/sclp.c | 7 +------
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
index 96cca2e..b3caff6 100644
--- a/lib/s390x/asm/arch_def.h
+++ b/lib/s390x/asm/arch_def.h
@@ -269,4 +269,17 @@ static inline int stsi(void *addr, int fc, int sel1, int sel2)
return cc;
}
+static inline int servc(uint32_t command, unsigned long sccb)
+{
+ int cc;
+
+ asm volatile(
+ " .insn rre,0xb2200000,%1,%2\n" /* servc %1,%2 */
+ " ipm %0\n"
+ " srl %0,28"
+ : "=&d" (cc) : "d" (command), "a" (sccb)
+ : "cc", "memory");
+ return cc;
+}
+
#endif
diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c
index a57096c..376040e 100644
--- a/lib/s390x/sclp.c
+++ b/lib/s390x/sclp.c
@@ -116,12 +116,7 @@ int sclp_service_call(unsigned int command, void *sccb)
int cc;
sclp_setup_int();
- asm volatile(
- " .insn rre,0xb2200000,%1,%2\n" /* servc %1,%2 */
- " ipm %0\n"
- " srl %0,28"
- : "=&d" (cc) : "d" (command), "a" (__pa(sccb))
- : "cc", "memory");
+ cc = servc(command, __pa(sccb));
sclp_wait_busy();
if (cc == 3)
return -1;
--
2.7.4
next prev parent reply other threads:[~2019-10-22 10:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 10:52 [kvm-unit-tests PATCH v1 0/5] s390x: SCLP Unit test Claudio Imbrenda
2019-10-22 10:53 ` [kvm-unit-tests PATCH v1 1/5] s390x: remove redundant defines Claudio Imbrenda
2019-10-22 11:54 ` Thomas Huth
2019-10-22 15:44 ` David Hildenbrand
2019-10-22 10:53 ` [kvm-unit-tests PATCH v1 2/5] s390x: improve error reporting for interrupts Claudio Imbrenda
2019-10-22 11:56 ` Thomas Huth
2019-10-22 15:44 ` David Hildenbrand
2019-10-22 10:53 ` [kvm-unit-tests PATCH v1 3/5] s390x: sclp: expose ram_size and max_ram_size Claudio Imbrenda
2019-10-22 12:16 ` Thomas Huth
2019-10-22 15:44 ` David Hildenbrand
2019-10-22 10:53 ` Claudio Imbrenda [this message]
2019-10-22 12:11 ` [kvm-unit-tests PATCH v1 4/5] s390x: sclp: add service call instruction wrapper Thomas Huth
2019-10-22 15:46 ` David Hildenbrand
2019-10-22 10:53 ` [kvm-unit-tests PATCH v1 5/5] s390x: SCLP unit test Claudio Imbrenda
2019-10-23 12:14 ` David Hildenbrand
2019-10-25 13:37 ` Claudio Imbrenda
2019-10-23 12:48 ` Thomas Huth
2019-10-24 15:40 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571741584-17621-5-git-send-email-imbrenda@linux.ibm.com \
--to=imbrenda@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox