From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>,
frankja@linux.ibm.com, imbrenda@linux.ibm.com, david@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v1 1/2] KVM: s390: gaccess: check if guest address is in memslot
Date: Wed, 18 Sep 2024 13:03:06 +0200 [thread overview]
Message-ID: <1583718b-43fd-4285-8392-936bb0ac89f2@linux.ibm.com> (raw)
In-Reply-To: <20240917151904.74314-2-nrb@linux.ibm.com>
Am 17.09.24 um 17:18 schrieb Nico Boehr:
> @@ -985,6 +988,10 @@ int access_guest_real(struct kvm_vcpu *vcpu, unsigned long gra,
> gra += fragment_len;
> data += fragment_len;
> }
> +
> + if (rc > 0)
> + vcpu->arch.pgm.code = rc;
This will work but using trans_exc might be more future proof I guess?
Otherwise this looks good with the nits fixed.
next prev parent reply other threads:[~2024-09-18 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 15:18 [PATCH v1 0/2] KVM: s390: fix diag258 virtual-physical confusion Nico Boehr
2024-09-17 15:18 ` [PATCH v1 1/2] KVM: s390: gaccess: check if guest address is in memslot Nico Boehr
2024-09-18 10:55 ` Heiko Carstens
2024-09-18 11:03 ` Christian Borntraeger [this message]
2024-09-17 15:18 ` [PATCH v1 2/2] KVM: s390: Change virtual to physical address access in diag 0x258 handler Nico Boehr
2024-09-18 10:46 ` Christian Borntraeger
2024-09-18 10:58 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583718b-43fd-4285-8392-936bb0ac89f2@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox