From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, me@kylehuey.com
Subject: Re: [PATCH] KVM: svm: support single stepping over emulated instructions
Date: Thu, 3 Aug 2017 01:30:19 -0400 (EDT) [thread overview]
Message-ID: <1586416935.1003490.1501738219700.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170802201338.GA32318@flask>
> We already have b742c1e6e79d ("KVM: SVM: handle singlestep exception
> when skipping emulated instructions"), so the only applicable part of
> this patch is
Doh. :)
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index 0e846f0cb83b..931ba449456e 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -5548,6 +5548,7 @@ static void kvm_vcpu_do_singlestep(struct kvm_vcpu
> > *vcpu, int *r)
> > */
> > vcpu->arch.dr6 &= ~15;
> > vcpu->arch.dr6 |= DR6_BS | DR6_RTM;
> > + kvm_update_dr6(vcpu);
> > kvm_queue_exception(vcpu, DB_VECTOR);
> > }
> > }
>
> which makes sense. And shouldn't we do the same for
> kvm_vcpu_check_breakpoint()?
Yes, will send v2.
Paolo
prev parent reply other threads:[~2017-08-03 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 16:03 [PATCH] KVM: svm: support single stepping over emulated instructions Paolo Bonzini
2017-08-02 20:13 ` Radim Krčmář
2017-08-03 5:30 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586416935.1003490.1501738219700.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@kylehuey.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox