Re: [kvm-unit-tests PATCH v13 6/9] s390x: Library resources for CSS tests

Janosch Frank
2020-07-16T11:31:15Z

[-- Attachment #1.1: Type: text/plain, Size: 1218 bytes --]

On 7/16/20 1:27 PM, Pierre Morel wrote:
>
>
> On 2020-07-16 13:15, Janosch Frank wrote:
>> On 7/16/20 10:23 AM, Pierre Morel wrote:
>>> Provide some definitions and library routines that can be used by
>>> tests targeting the channel subsystem.
>>>
>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>> Acked-by: Thomas Huth <thuth@redhat.com>
>>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>>> Acked-by: Janosch Frank <frankja@de.ibm.com>
>>> ---
>> [...]
>>> diff --git a/s390x/Makefile b/s390x/Makefile
>>> index ddb4b48..050c40b 100644
>>> --- a/s390x/Makefile
>>> +++ b/s390x/Makefile
>>> @@ -51,6 +51,7 @@ cflatobjs += lib/s390x/sclp-console.o
>>> cflatobjs += lib/s390x/interrupt.o
>>> cflatobjs += lib/s390x/mmu.o
>>> cflatobjs += lib/s390x/smp.o
>>> +cflatobjs += lib/s390x/css_dump.o
>>>
>>> OBJDIRS += lib/s390x
>>>
>>
>> I need to fix this up when picking because Thomas added vm.o after smp.o.
>> Can I do that or do you want to rebase on my next branch?
>>
>>
>
> I can do it and respin, that will give me the occasion to suppress the
> goto as demanded by Thomas.
>
> Is it OK?
>

I won't say no to other people doing my work :)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]