From: Dave Hansen <dave.hansen@intel.com>
To: Sean Christopherson <seanjc@google.com>, Chao Gao <chao.gao@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, tglx@linutronix.de, pbonzini@redhat.com,
peterz@infradead.org, rick.p.edgecombe@intel.com,
weijiang.yang@intel.com, john.allen@amd.com, bp@alien8.de,
chang.seok.bae@intel.com, xin3.li@intel.com,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
Eric Biggers <ebiggers@google.com>,
Stanislav Spassov <stanspas@amazon.de>,
Kees Cook <kees@kernel.org>
Subject: Re: [PATCH v6 5/7] x86/fpu: Initialize guest fpstate and FPU pseudo container from guest defaults
Date: Wed, 7 May 2025 11:04:05 -0700 [thread overview]
Message-ID: <15c80733-5cd8-4d9a-9fda-0d0ec305ac6b@intel.com> (raw)
In-Reply-To: <aBuf7wiiDT0Wflhk@google.com>
On 5/7/25 11:01, Sean Christopherson wrote:
> And then a follow-up patch (or same patch?) to do this?
>
> if (fpstate->is_guest) {
> fpstate->size = guest_default_cfg.size;
> fpstate->xfeatures = guest_default_cfg.features;
> fpstate->xfd = 0;
> } else {
> fpstate->size = fpu_kernel_cfg.default_size;
> fpstate->xfeatures = fpu_kernel_cfg.default_features;
> fpstate->xfd = init_fpstate.xfd;
> }
That looks nice because it clearly highlights how guests and bare-metal
fpstates are different. I like it too.
next prev parent reply other threads:[~2025-05-07 18:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 9:36 [PATCH v6 0/7] Introduce CET supervisor state support Chao Gao
2025-05-06 9:36 ` [PATCH v6 1/7] x86/fpu/xstate: Always preserve non-user xfeatures/flags in __state_perm Chao Gao
2025-05-06 9:51 ` [tip: x86/fpu] " tip-bot2 for Sean Christopherson
2025-05-06 9:36 ` [PATCH v6 2/7] x86/fpu: Drop @perm from guest pseudo FPU container Chao Gao
2025-05-06 9:36 ` [PATCH v6 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs Chao Gao
2025-05-08 20:02 ` Edgecombe, Rick P
2025-05-06 9:36 ` [PATCH v6 4/7] x86/fpu: Initialize guest FPU permissions from guest defaults Chao Gao
2025-05-06 9:36 ` [PATCH v6 5/7] x86/fpu: Initialize guest fpstate and FPU pseudo container " Chao Gao
2025-05-06 17:24 ` Sean Christopherson
2025-05-07 7:37 ` Chao Gao
2025-05-07 18:01 ` Sean Christopherson
2025-05-07 18:04 ` Dave Hansen [this message]
2025-05-09 8:14 ` [PATCH v6a 5/8] " Chao Gao
2025-05-09 8:16 ` [PATCH v6a 6/8] x86/fpu: Remove xfd argument from __fpstate_reset() Chao Gao
2025-05-09 18:29 ` Sean Christopherson
2025-05-06 9:36 ` [PATCH v6 6/7] x86/fpu/xstate: Introduce "guest-only" supervisor xfeature set Chao Gao
2025-05-06 9:36 ` [PATCH v6 7/7] x86/fpu/xstate: Add CET supervisor xfeature support as a guest-only feature Chao Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15c80733-5cd8-4d9a-9fda-0d0ec305ac6b@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@google.com \
--cc=hpa@zytor.com \
--cc=john.allen@amd.com \
--cc=kees@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=stanspas@amazon.de \
--cc=tglx@linutronix.de \
--cc=weijiang.yang@intel.com \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox