From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: VMX: require virtual NMI support Date: Wed, 13 Sep 2017 22:34:26 +0200 Message-ID: <16056526-1fc8-4ad8-5308-c16110d12e88@redhat.com> References: <1490618297-10581-2-git-send-email-pbonzini@redhat.com> <37c3939f-6c5e-1f88-5642-a5efb3ece1c4@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: rkrcmar@redhat.com To: Zdenek Kaspar , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55454 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdIMUeb (ORCPT ); Wed, 13 Sep 2017 16:34:31 -0400 In-Reply-To: <37c3939f-6c5e-1f88-5642-a5efb3ece1c4@gmail.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 13/09/2017 19:23, Zdenek Kaspar wrote: > On 03/27/2017 02:38 PM, Paolo Bonzini wrote: >> Virtual NMIs are only missing in Prescott and Yonah chips. Both are obsolete >> for virtualization usage---Yonah is 32-bit only even---so drop vNMI emulation. >> >> Signed-off-by: Paolo Bonzini >> --- >> arch/x86/kvm/vmx.c | 143 ++++++++++++++--------------------------------------- >> 1 file changed, 38 insertions(+), 105 deletions(-) > > This breaks virtualization on old Intel Core2 machines. > Any chance to revert? Already planned for 4.14 and future 4.13 stable kernels, but haven't gotten round to it. Paolo