From: Pierre Morel <pmorel@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com,
cohuck@redhat.com, imbrenda@linux.ibm.com
Subject: [kvm-unit-tests PATCH v2 4/8] s390x: lib: css: separate wait for IRQ and check I/O completion
Date: Thu, 25 Mar 2021 10:39:03 +0100 [thread overview]
Message-ID: <1616665147-32084-5-git-send-email-pmorel@linux.ibm.com> (raw)
In-Reply-To: <1616665147-32084-1-git-send-email-pmorel@linux.ibm.com>
We will may want to check the result of an I/O without waiting
for an interrupt.
For example because we do not handle interrupt.
Let's separate waiting for interrupt and the I/O complretion check.
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
---
lib/s390x/css.h | 1 +
lib/s390x/css_lib.c | 13 ++++++++++---
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/s390x/css.h b/lib/s390x/css.h
index 0058355..5d1e1f0 100644
--- a/lib/s390x/css.h
+++ b/lib/s390x/css.h
@@ -317,6 +317,7 @@ int css_residual_count(unsigned int schid);
void enable_io_isc(uint8_t isc);
int wait_and_check_io_completion(int schid);
+int check_io_completion(int schid);
/*
* CHSC definitions
diff --git a/lib/s390x/css_lib.c b/lib/s390x/css_lib.c
index f5c4f37..1e5c409 100644
--- a/lib/s390x/css_lib.c
+++ b/lib/s390x/css_lib.c
@@ -487,18 +487,25 @@ struct ccw1 *ccw_alloc(int code, void *data, int count, unsigned char flags)
}
/* wait_and_check_io_completion:
+ * @schid: the subchannel ID
+ */
+int wait_and_check_io_completion(int schid)
+{
+ wait_for_interrupt(PSW_MASK_IO);
+ return check_io_completion(schid);
+}
+
+/* check_io_completion:
* @schid: the subchannel ID
*
* Makes the most common check to validate a successful I/O
* completion.
* Only report failures.
*/
-int wait_and_check_io_completion(int schid)
+int check_io_completion(int schid)
{
int ret = 0;
- wait_for_interrupt(PSW_MASK_IO);
-
report_prefix_push("check I/O completion");
if (lowcore_ptr->io_int_param != schid) {
--
2.17.1
next prev parent reply other threads:[~2021-03-25 9:40 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 9:38 [kvm-unit-tests PATCH v2 0/8] Testing SSCH, CSCH and HSCH for errors Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 1/8] s390x: lib: css: disabling a subchannel Pierre Morel
2021-03-25 14:52 ` Claudio Imbrenda
2021-03-25 16:10 ` Pierre Morel
2021-03-26 8:26 ` Janosch Frank
2021-03-26 9:02 ` Pierre Morel
2021-03-29 8:00 ` Thomas Huth
2021-03-29 12:33 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 2/8] s390x: lib: css: SCSW bit definitions Pierre Morel
2021-03-25 15:00 ` Claudio Imbrenda
2021-03-25 16:13 ` Pierre Morel
2021-03-29 8:09 ` Thomas Huth
2021-03-29 12:25 ` Pierre Morel
2021-03-30 11:49 ` Cornelia Huck
2021-03-30 12:59 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 3/8] s390x: css: simplify skipping tests on no device Pierre Morel
2021-03-25 15:21 ` Claudio Imbrenda
2021-03-25 16:21 ` Pierre Morel
2021-03-26 8:41 ` Janosch Frank
2021-03-26 9:04 ` Pierre Morel
2021-03-29 8:19 ` Thomas Huth
2021-03-29 12:39 ` Pierre Morel
2021-03-29 12:50 ` Pierre Morel
2021-03-30 11:52 ` Cornelia Huck
2021-03-30 12:58 ` Pierre Morel
2021-03-25 9:39 ` Pierre Morel [this message]
2021-03-25 15:24 ` [kvm-unit-tests PATCH v2 4/8] s390x: lib: css: separate wait for IRQ and check I/O completion Claudio Imbrenda
2021-03-25 16:23 ` Pierre Morel
2021-03-29 8:21 ` Thomas Huth
2021-03-29 11:00 ` Pierre Morel
2021-03-30 11:57 ` Cornelia Huck
2021-03-30 12:57 ` Pierre Morel
2021-04-01 8:24 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 5/8] s390x: lib: css: add SCSW ctrl expectations to " Pierre Morel
2021-03-25 15:40 ` Claudio Imbrenda
2021-03-29 8:27 ` Thomas Huth
2021-03-29 8:32 ` Thomas Huth
2021-03-29 11:01 ` Pierre Morel
2021-03-29 11:02 ` Pierre Morel
2021-03-30 12:10 ` Cornelia Huck
2021-03-30 12:54 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 6/8] s390x: css: testing ssch error response Pierre Morel
2021-03-25 16:02 ` Claudio Imbrenda
2021-03-25 17:23 ` Pierre Morel
2021-03-26 10:41 ` Pierre Morel
2021-03-26 10:58 ` Claudio Imbrenda
2021-03-29 7:42 ` Pierre Morel
2021-03-30 13:01 ` Pierre Morel
2021-03-29 9:40 ` Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 7/8] s390x: css: testing halt subchannel Pierre Morel
2021-03-25 9:39 ` [kvm-unit-tests PATCH v2 8/8] s390x: css: testing clear subchannel Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616665147-32084-5-git-send-email-pmorel@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox