From: Pierre Morel <pmorel@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com,
cohuck@redhat.com, imbrenda@linux.ibm.com
Subject: [kvm-unit-tests PATCH v3 10/16] s390x: css: ssch checking addressing errors
Date: Tue, 6 Apr 2021 09:40:47 +0200 [thread overview]
Message-ID: <1617694853-6881-11-git-send-email-pmorel@linux.ibm.com> (raw)
In-Reply-To: <1617694853-6881-1-git-send-email-pmorel@linux.ibm.com>
We check ORB CPA and CCW address for being inside limits
and existing.
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
---
s390x/css.c | 79 +++++++++++++++++++++++++++++++++++++++++++++
s390x/unittests.cfg | 8 +++--
2 files changed, 85 insertions(+), 2 deletions(-)
diff --git a/s390x/css.c b/s390x/css.c
index 47452ba..f8f91cf 100644
--- a/s390x/css.c
+++ b/s390x/css.c
@@ -16,6 +16,7 @@
#include <asm/arch_def.h>
#include <alloc_page.h>
#include <alloc.h>
+#include <sclp.h>
#include <malloc_io.h>
#include <css.h>
@@ -34,6 +35,12 @@ static struct senseid *senseid;
struct ccw1 *ccw;
struct orb *orb;
+phys_addr_t ram_size;
+#define ADDR_1G 0x40000000
+#define ADDR_1_5G 0x60000000
+#define ADDR_3G 0xc0000000
+
+
static void test_enumerate(void)
{
test_device_sid = css_enumerate();
@@ -123,10 +130,80 @@ static void ssch_orb_alignment(void)
free_pages(p - 2);
}
+static void ssch_data_access(void)
+{
+ uint32_t tmp;
+
+ if (ram_size > ADDR_1G) {
+ report_skip("Test with more than 1G available memory");
+ return;
+ }
+
+ tmp = ccw->data_address;
+ ccw->data_address = ADDR_1_5G;
+
+ ssch(test_device_sid, orb);
+ tsch(test_device_sid, &irb);
+ report(check_io_errors(test_device_sid, 0, SCSW_SCHS_PRG_CHK), "expecting Program check");
+
+ ccw->data_address = tmp;
+}
+
+static void ssch_ccw_access(void)
+{
+ uint32_t tmp;
+
+ if (ram_size > ADDR_1G) {
+ report_skip("Test with more than 1G available memory");
+ return;
+ }
+
+ tmp = orb->cpa;
+ orb->cpa = ADDR_1_5G;
+
+ ssch(test_device_sid, orb);
+ tsch(test_device_sid, &irb);
+ report(check_io_errors(test_device_sid, 0, SCSW_SCHS_PRG_CHK), "expecting Program check");
+
+ orb->cpa = tmp;
+}
+
+static void ssch_ccw_dma31(void)
+{
+ uint32_t tmp;
+ struct ccw1 *ccw_high;
+
+ if (ram_size < ADDR_3G) {
+ report_skip("Test with less than 3G available memory");
+ return;
+ }
+
+ ccw_high = alloc_pages_flags(0, AREA_NORMAL);
+ assert(ccw_high);
+ ccw_high->code = CCW_CMD_SENSE_ID;
+ ccw_high->flags = CCW_F_SLI;
+ ccw_high->count = sizeof(*senseid);
+ ccw_high->data_address = (long)senseid;
+
+ tmp = orb->cpa;
+ report_info("ccw_high: %p", ccw_high);
+ orb->cpa = (long)ccw_high;
+
+ expect_pgm_int();
+ ssch(test_device_sid, orb);
+ check_pgm_int_code(PGM_INT_CODE_OPERAND);
+
+ orb->cpa = tmp;
+ free_pages(ccw_high);
+}
+
static struct tests ssh_tests[] = {
{ "privilege", ssch_privilege },
{ "orb cpa zero", ssch_orb_cpa_zero },
{ "orb alignment", ssch_orb_alignment },
+ { "data access", ssch_data_access },
+ { "CCW access", ssch_ccw_access },
+ { "CCW in DMA31", ssch_ccw_dma31 },
{ NULL, NULL }
};
@@ -136,6 +213,7 @@ static void test_ssch(void)
orb_alloc();
assert(css_enable(test_device_sid, 0) == 0);
+ ram_size = get_ram_size();
for (i = 0; ssh_tests[i].name; i++) {
report_prefix_push(ssh_tests[i].name);
@@ -144,6 +222,7 @@ static void test_ssch(void)
}
orb_free();
+ css_enable(test_device_sid, 0);
}
/*
diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
index 9f81a60..45569dc 100644
--- a/s390x/unittests.cfg
+++ b/s390x/unittests.cfg
@@ -86,9 +86,13 @@ extra_params = -m 1G
file = sclp.elf
extra_params = -m 3G
-[css]
+[css-1g]
file = css.elf
-extra_params = -device virtio-net-ccw
+extra_params = -m 1G -device virtio-net-ccw
+
+[css-3g]
+file = css.elf
+extra_params = -m 3G -device virtio-net-ccw
[skrf]
file = skrf.elf
--
2.17.1
next prev parent reply other threads:[~2021-04-06 7:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 7:40 [kvm-unit-tests PATCH v3 00/16] s390x: Testing SSCH, CSCH and HSCH for errors Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 01/16] s390x: lib: css: disabling a subchannel Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 02/16] s390x: lib: css: SCSW bit definitions Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 03/16] s390x: css: simplify skipping tests on no device Pierre Morel
2021-04-06 12:44 ` Cornelia Huck
2021-04-07 10:53 ` Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 04/16] s390x: lib: css: separate wait for IRQ and check I/O completion Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 05/16] s390x: lib: css: add SCSW ctrl expectations to " Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 06/16] s390x: lib: css: checking I/O errors Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 07/16] s390x: css: testing ssch errors Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 08/16] s390x: css: ssch check for cpa zero Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 09/16] s390x: css: ssch with mis aligned ORB Pierre Morel
2021-04-06 7:40 ` Pierre Morel [this message]
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 11/16] s390x: css: No support for MIDAW Pierre Morel
2021-04-06 15:58 ` Cornelia Huck
2021-04-07 10:06 ` Pierre Morel
2021-04-07 10:14 ` Cornelia Huck
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 12/16] s390x: css: Check ORB reserved bits Pierre Morel
2021-04-06 15:51 ` Cornelia Huck
2021-04-07 10:07 ` Pierre Morel
2021-04-07 10:15 ` Cornelia Huck
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 13/16] s390x: css: checking for CSS extensions Pierre Morel
2021-04-06 15:50 ` Cornelia Huck
2021-04-07 10:42 ` Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 14/16] s390x: css: issuing SSCH when the channel is status pending Pierre Morel
2021-04-06 15:34 ` Cornelia Huck
2021-04-07 10:46 ` Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 15/16] s390x: css: testing halt subchannel Pierre Morel
2021-04-06 7:40 ` [kvm-unit-tests PATCH v3 16/16] s390x: css: testing clear subchannel Pierre Morel
2021-04-06 12:21 ` [kvm-unit-tests PATCH v3 00/16] s390x: Testing SSCH, CSCH and HSCH for errors Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617694853-6881-11-git-send-email-pmorel@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox