[kvm-unit-tests PATCH 1/2] x86/hyperv: Use correct macro in checking SynIC timer support

[kvm-unit-tests PATCH 1/2] x86/hyperv: Use correct macro in checking SynIC timer support

[Kaya, Metin]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

This commit fixes 69d4bf751641520f5b2d8e3f160c63c8966fcd8b. stimer_supported() should use HV_X64_MSR_SYNTIMER_AVAILABLE instead of HV_X64_MSR_SYNIC_AVAILABLE.​

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-x86-hyperv-Use-correct-macro-in-checking-SynIC-timer.patch --]
[-- Type: text/x-patch; name="0001-x86-hyperv-Use-correct-macro-in-checking-SynIC-timer.patch", Size: 969 bytes --]

From 3e31f7d2b7bfc92ff710e3061b32301f96862b8b Mon Sep 17 00:00:00 2001
From: Metin Kaya <metikaya@amazon.com>
Date: Wed, 22 Dec 2021 18:22:28 +0000
Subject: [kvm-unit-tests PATCH 1/2] x86/hyperv: Use correct macro in checking
 SynIC timer support

This commit fixes 69d4bf751641520f5b2d8e3f160c63c8966fcd8b.
stimer_supported() should use HV_X64_MSR_SYNTIMER_AVAILABLE instead of
HV_X64_MSR_SYNIC_AVAILABLE.

Signed-off-by: Metin Kaya <metikaya@amazon.com>
---
 x86/hyperv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/x86/hyperv.h b/x86/hyperv.h
index e135221..f2bb7b4 100644
--- a/x86/hyperv.h
+++ b/x86/hyperv.h
@@ -190,7 +190,7 @@ static inline bool synic_supported(void)
 
 static inline bool stimer_supported(void)
 {
-    return cpuid(HYPERV_CPUID_FEATURES).a & HV_X64_MSR_SYNIC_AVAILABLE;
+    return cpuid(HYPERV_CPUID_FEATURES).a & HV_X64_MSR_SYNTIMER_AVAILABLE;
 }
 
 static inline bool hv_time_ref_counter_supported(void)
-- 
2.32.0

Re: [kvm-unit-tests PATCH 1/2] x86/hyperv: Use correct macro in checking SynIC timer support

[Vitaly Kuznetsov]

"Kaya, Metin" <metikaya@amazon.com> writes:

> This commit fixes 69d4bf751641520f5b2d8e3f160c63c8966fcd8b. stimer_supported() should use HV_X64_MSR_SYNTIMER_AVAILABLE instead of HV_X64_MSR_SYNIC_AVAILABLE.​
> From 3e31f7d2b7bfc92ff710e3061b32301f96862b8b Mon Sep 17 00:00:00 2001
> From: Metin Kaya <metikaya@amazon.com>
> Date: Wed, 22 Dec 2021 18:22:28 +0000
> Subject: [kvm-unit-tests PATCH 1/2] x86/hyperv: Use correct macro in checking
>  SynIC timer support
>
> This commit fixes 69d4bf751641520f5b2d8e3f160c63c8966fcd8b.
> stimer_supported() should use HV_X64_MSR_SYNTIMER_AVAILABLE instead of
> HV_X64_MSR_SYNIC_AVAILABLE.
>

Fixes: 69d4bf7 ("x86: Hyper-V SynIC timers test")
> Signed-off-by: Metin Kaya <metikaya@amazon.com>
> ---
>  x86/hyperv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/hyperv.h b/x86/hyperv.h
> index e135221..f2bb7b4 100644
> --- a/x86/hyperv.h
> +++ b/x86/hyperv.h
> @@ -190,7 +190,7 @@ static inline bool synic_supported(void)
>  
>  static inline bool stimer_supported(void)
>  {
> -    return cpuid(HYPERV_CPUID_FEATURES).a & HV_X64_MSR_SYNIC_AVAILABLE;
> +    return cpuid(HYPERV_CPUID_FEATURES).a & HV_X64_MSR_SYNTIMER_AVAILABLE;
>  }

Unrelated to the change but I'd suggest renaming stimer_supported() to
hv_stimer_supported() and synic_supported() to hv_synic_supported().

>  
>  static inline bool hv_time_ref_counter_supported(void)

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

-- 
Vitaly

Re: [kvm-unit-tests PATCH 1/2] x86/hyperv: Use correct macro in checking SynIC timer support

[Kaya, Metin]

Thanks, Vitaly. Will send another patch for it. 
________________________________________
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Sent: 04 January 2022 16:32
To: Kaya, Metin
Cc: kvm@vger.kernel.org
Subject: RE: [EXTERNAL] [kvm-unit-tests PATCH 1/2] x86/hyperv: Use correct macro in checking SynIC timer support

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



"Kaya, Metin" <metikaya@amazon.com> writes:

> This commit fixes 69d4bf751641520f5b2d8e3f160c63c8966fcd8b. stimer_supported() should use HV_X64_MSR_SYNTIMER_AVAILABLE instead of HV_X64_MSR_SYNIC_AVAILABLE.​
> From 3e31f7d2b7bfc92ff710e3061b32301f96862b8b Mon Sep 17 00:00:00 2001
> From: Metin Kaya <metikaya@amazon.com>
> Date: Wed, 22 Dec 2021 18:22:28 +0000
> Subject: [kvm-unit-tests PATCH 1/2] x86/hyperv: Use correct macro in checking
>  SynIC timer support
>
> This commit fixes 69d4bf751641520f5b2d8e3f160c63c8966fcd8b.
> stimer_supported() should use HV_X64_MSR_SYNTIMER_AVAILABLE instead of
> HV_X64_MSR_SYNIC_AVAILABLE.
>

Fixes: 69d4bf7 ("x86: Hyper-V SynIC timers test")
> Signed-off-by: Metin Kaya <metikaya@amazon.com>
> ---
>  x86/hyperv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/hyperv.h b/x86/hyperv.h
> index e135221..f2bb7b4 100644
> --- a/x86/hyperv.h
> +++ b/x86/hyperv.h
> @@ -190,7 +190,7 @@ static inline bool synic_supported(void)
>
>  static inline bool stimer_supported(void)
>  {
> -    return cpuid(HYPERV_CPUID_FEATURES).a & HV_X64_MSR_SYNIC_AVAILABLE;
> +    return cpuid(HYPERV_CPUID_FEATURES).a & HV_X64_MSR_SYNTIMER_AVAILABLE;
>  }

Unrelated to the change but I'd suggest renaming stimer_supported() to
hv_stimer_supported() and synic_supported() to hv_synic_supported().

>
>  static inline bool hv_time_ref_counter_supported(void)

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

--
Vitaly