From: Will Deacon <will@kernel.org>
To: kvm@vger.kernel.org, Thomas Perale <thomas.perale@mind.be>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH kvmtool] vfio: include libgen.h (for musl compatibility)
Date: Mon, 21 Jul 2025 15:35:51 +0100 [thread overview]
Message-ID: <175309922953.3722631.3586573998054640008.b4-ty@kernel.org> (raw)
In-Reply-To: <20250629202221.893360-1-thomas.perale@mind.be>
On Sun, 29 Jun 2025 22:22:21 +0200, Thomas Perale wrote:
> Starting GCC14 'implicit-function-declaration' are treated as errors by
> default. When building kvmtool with musl libc, the following error
> occurs due to missing declaration of 'basename':
>
> vfio/core.c:537:22: error: implicit declaration of function ‘basename’ [-Wimplicit-function-declaration]
> 537 | group_name = basename(group_path);
> | ^~~~~~~~
> vfio/core.c:537:22: warning: nested extern declaration of ‘basename’ [-Wnested-externs]
> vfio/core.c:537:20: error: assignment to ‘char *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> 537 | group_name = basename(group_path);
> | ^
>
> [...]
Applied to kvmtool (master), thanks!
[1/1] vfio: include libgen.h (for musl compatibility)
https://git.kernel.org/will/kvmtool/c/ba6830eec0f5
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2025-07-21 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 20:22 [PATCH kvmtool] vfio: include libgen.h (for musl compatibility) Thomas Perale
2025-06-30 9:02 ` Alexandru Elisei
2025-06-30 9:04 ` Alexandru Elisei
2025-07-21 14:35 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175309922953.3722631.3586573998054640008.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=thomas.perale@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox