Re: [PATCH] KVM: remove printing of token address

Tobin C. Harding
2017-10-09T10:04:15Z

On Mon, Oct 09, 2017 at 03:49:38AM -0400, Paolo Bonzini wrote:
>
>
> ----- Original Message -----
> > From: "Tobin C. Harding" <me@tobin.cc>
> > To: "Paolo Bonzini" <pbonzini@redhat.com>, rkrcmar@redhat.com
> > Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Tobin C. Harding" <me@tobin.cc>
> > Sent: Monday, October 9, 2017 8:30:14 AM
> > Subject: [PATCH] KVM: remove printing of token address
> >
> > KVM currently prints the address of the consumer token. It is not
> > immediately clear what benefit it is to see this address. Printing
> > this address leaks kernel pointers into dmesg and is a security risk.
> >
> > Remove the consumer token address from error message output.
>
> It should use %pK instead.

Is there any other way we can identify a token? There is some push back against kpt_restrict (as
used by %pK) at the moment. If there is another sane way to do it perhaps we could consider that,
else I'll use %pK for v2.

> Also, please do the same change on the VFIO
> side (drivers/vfio/pci/vfio_pci_intrs.c, call to irq_bypass_register_producer).

Oh, cool. I was wondering where the other side was. Will send v2

thanks,
Tobin.