From: "Yang, Weijiang" <weijiang.yang@intel.com>
To: Like Xu <like.xu.linux@gmail.com>, Jim Mattson <jmattson@google.com>
Cc: kvm@vger.kernel.org,
"Paolo Bonzini - Distinguished Engineer (kernel-recipes.org)
(KVM HoF)" <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 3/3] x86: Skip perf related tests when pmu is disabled
Date: Fri, 10 Jun 2022 14:03:58 +0800 [thread overview]
Message-ID: <18ca771e-9901-5730-ff7a-d3ce935687de@intel.com> (raw)
In-Reply-To: <a77e6ccf-e694-b71d-b4e6-fa851459382c@gmail.com>
On 6/10/2022 12:56 PM, Like Xu wrote:
> On 10/6/2022 12:22 pm, Jim Mattson wrote:
>> On Thu, Jun 9, 2022 at 9:16 PM Jim Mattson <jmattson@google.com> wrote:
>>>
>>> On Thu, Jun 9, 2022 at 7:49 PM Like Xu <like.xu.linux@gmail.com> wrote:
>>>
>>>> RDPMC Intel Operation:
>>
>> Actually, the key phrase is also present in the pseudocode you quoted:
>>
>>>> MSCB = Most Significant Counter Bit (* Model-specific *)
>>>> IF (((CR4.PCE = 1) or (CPL = 0) or (CR0.PE = 0)) and (ECX indicates
>>>> a supported
>>>> counter))
>> ...
>>
>> The final conjunct in that condition is false under KVM when
>> !enable_pmu, because there are no supported counters.
>
> Uh, I have lifted a stone and smashed my own feet.
>
> Please move on with #GP expectation.
Thank you two!
next prev parent reply other threads:[~2022-06-10 6:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 8:39 [kvm-unit-tests PATCH 0/3] Fix up test failures induced by !enable_pmu Yang Weijiang
2022-06-09 8:39 ` [kvm-unit-tests PATCH 1/3] x86: Remove perf enable bit from default config Yang Weijiang
2022-06-09 8:39 ` [kvm-unit-tests PATCH 2/3] x86: Skip running test when pmu is disabled Yang Weijiang
2022-06-09 23:57 ` Like Xu
2022-06-10 1:40 ` Yang, Weijiang
2022-06-09 8:39 ` [kvm-unit-tests PATCH 3/3] x86: Skip perf related tests " Yang Weijiang
2022-06-10 0:14 ` Like Xu
2022-06-10 1:47 ` Yang, Weijiang
2022-06-10 2:24 ` Jim Mattson
2022-06-10 2:48 ` Like Xu
2022-06-10 4:16 ` Jim Mattson
2022-06-10 4:22 ` Jim Mattson
2022-06-10 4:56 ` Like Xu
2022-06-10 6:03 ` Yang, Weijiang [this message]
2022-06-10 0:02 ` [kvm-unit-tests PATCH 0/3] Fix up test failures induced by !enable_pmu Like Xu
2022-06-10 6:29 ` Yang, Weijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ca771e-9901-5730-ff7a-d3ce935687de@intel.com \
--to=weijiang.yang@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox