kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Zhiping Zhang <zhipingz@meta.com>,
	Alex Williamson <alex@shazbot.org>,
	Leon Romanovsky <leon@kernel.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	kvm@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-pci@vger.kernel.org, netdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Keith Busch <kbusch@kernel.org>,
	Yochai Cohen <yochai@nvidia.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Linus Torvalds <torvalds@linuxfoundation.org>
Subject: Re: [PATCH v5 0/4] vfio/dma-buf: add TPH support for peer-to-peer access
Date: Mon, 1 Jun 2026 11:59:55 +0200	[thread overview]
Message-ID: <190a1eeb-bd70-4b7b-93a4-60e14f0d6c7e@amd.com> (raw)
In-Reply-To: <20260529201130.GU2487554@ziepe.ca>

On 5/29/26 22:11, Jason Gunthorpe wrote:
> On Fri, May 29, 2026 at 09:36:00AM +0200, Christian König wrote:
>> On 5/29/26 08:34, Zhiping Zhang wrote:
>> ...
>>> There's no in-tree vendor PF driver
>>
>> Well I have to admit it's a bit on the edge but this sentence is a
>> show stopper.
> 
> I think he means the device is not SRIOV. vfio-pci is the in-kernel PF
> driver.
> 
>> DMA-buf is an in kernel interface for buffer sharing between drivers
>> and any change to it needs an in kernel driver as justification for
>> the added complexity.
> 
> vfio is the in-kernel driver, this series fully shows the in-kernel
> API using vfio as the exporter and mlx5 as the importer. It certainly
> meets the standard required to show in-tree users.
> 
>> When you have a complete open source driver stack which utilizes
>> VFIO passthrough as the interface to communicate with the kernel
>> drivers then we can eventually talk about that.
> 
> That decision is not up to dmabuf

Yes it is. This is the DMA-buf API which is added here.

> - what VFIO subsystem requires to
> accept a new UAPI is up to the VFIO maintainers.

As far as I can see vfio-pci is used as a stub driver to avoid opening up the real driver.

Upstreaming an API changes only makes sense if others can use it and this here is something completely special to this particular use case, without all components involved nobody else can use it.

So as far as I can see that here is a no-go. But at the end of the day it's Linus who needs to say if that's ok or not, that's why I put him on CC.

Regards,
Christian.

> DRM and VFIO have very different views on what is required to merge a
> new uAPI.
> 
> Jason


  reply	other threads:[~2026-06-01 10:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260526144401.1485788-1-zhipingz@meta.com>
2026-05-27  6:55 ` [PATCH v5 0/4] vfio/dma-buf: add TPH support for peer-to-peer access Christian König
2026-05-27 12:14   ` Jason Gunthorpe
2026-05-27 12:23     ` Christian König
2026-05-27 12:36       ` Jason Gunthorpe
2026-05-27 12:53         ` Christian König
2026-05-28  4:55           ` Zhiping Zhang
2026-05-28  7:46             ` Christian König
2026-05-29  6:34               ` Zhiping Zhang
2026-05-29  7:36                 ` Christian König
2026-05-29 20:11                   ` Jason Gunthorpe
2026-06-01  9:59                     ` Christian König [this message]
2026-06-01 17:47                       ` Jason Gunthorpe
2026-06-01 18:17                         ` Christian König
2026-06-01 18:48                           ` Jason Gunthorpe
2026-06-02  7:14                             ` Zhiping Zhang
2026-05-29 20:31                   ` Keith Busch
2026-06-01 10:03                     ` Christian König
2026-06-01 17:50                     ` Jason Gunthorpe
     [not found] ` <20260526144401.1485788-3-zhipingz@meta.com>
2026-05-27  6:57   ` [PATCH v5 2/4] dma-buf: add optional get_tph() callback Christian König
2026-05-27 17:03   ` Alex Williamson
     [not found] ` <20260526144401.1485788-4-zhipingz@meta.com>
2026-05-27 18:06   ` [PATCH v5 3/4] vfio/pci: implement get_tph and DMA_BUF_TPH feature Alex Williamson
2026-05-28  5:34     ` Zhiping Zhang
     [not found] ` <20260526144401.1485788-5-zhipingz@meta.com>
2026-05-27 19:00   ` [PATCH v5 4/4] RDMA/mlx5: get tph for p2p access when registering dma-buf mr Alex Williamson
2026-05-28  5:54     ` Zhiping Zhang
2026-05-27 22:55   ` Michael Gur
2026-05-28  6:07     ` Zhiping Zhang
     [not found] ` <20260526144401.1485788-2-zhipingz@meta.com>
2026-05-27 20:53   ` [PATCH v5 1/4] PCI/TPH: expose the enabled TPH requester type Alex Williamson
2026-05-28  5:35     ` Zhiping Zhang
2026-05-28  8:04       ` fengchengwen
2026-05-29  6:41         ` Zhiping Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=190a1eeb-bd70-4b7b-93a4-60e14f0d6c7e@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alex@shazbot.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kbusch@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=torvalds@linuxfoundation.org \
    --cc=yishaih@nvidia.com \
    --cc=yochai@nvidia.com \
    --cc=zhipingz@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).