From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akio Takebe Subject: Re: include files for kvmclock Date: Wed, 07 Nov 2007 17:16:37 +0900 Message-ID: <1DC8211684B62Btakebe_akio@jp.fujitsu.com> References: <11943875362987-git-send-email-gcosta@redhat.com> <11943875433821-git-send-email-gcosta@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jeremy-TSDbQ3PG+2Y@public.gmane.org, avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org, hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org To: Glauber de Oliveira Costa , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <11943875433821-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hi, Glauber This is interesting facility. :-) >+#define KVM_HCALL_REGISTER_CLOCK 1 >+ >+union kvm_hv_clock { >+ struct { >+ u64 tsc_mult; >+ u64 now_ns; >+ /* That's the wall clock, not the water closet */ >+ u64 wc_sec; >+ u64 wc_nsec; >+ u64 last_tsc; >+ /* At first, we could use the tsc value as a marker, but Jeremy >+ * well noted that it will cause us locking problems in 32-bit >+ * sys, so we have a special version field */ >+ u32 version; >+ }; >+ char page_align[PAGE_SIZE]; >+}; >+ Why does kvm_hv_clock need page_align? And also the kvm_hv_clock is alloced with kvm_vcpu, so the align is not enough, isn't it? I thik __atribute__((__aligne__(PAGE_SIZE)))) is better than it. Best Regards, Akio Takebe ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/