From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akio Takebe Subject: Re: include files for kvmclock Date: Wed, 07 Nov 2007 22:27:46 +0900 Message-ID: <1FC82141FC3CCFtakebe_akio@jp.fujitsu.com> References: <11943875362987-git-send-email-gcosta@redhat.com> <11943875433821-git-send-email-gcosta@redhat.com> <1DC8211684B62Btakebe_akio@jp.fujitsu.com> <4731BAB2.9040004@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: jeremy-TSDbQ3PG+2Y@public.gmane.org, hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Akio Takebe , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org To: Glauber de Oliveira Costa Return-path: In-Reply-To: <4731BAB2.9040004-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hi, >> Why does kvm_hv_clock need page_align? >Each vcpu will register a page on its own. In the guest side, it will be >an array of pages. So, we make it page sized. > >> And also the kvm_hv_clock is alloced with kvm_vcpu, >There's no requirements on the host part at all. So it doesn't really >matter. In the next version, I may make it even a simple pointer. > >> so the align is not enough, isn't it? >> I thik __atribute__((__aligne__(PAGE_SIZE)))) is better than it. >It deals with the start of the structure, but not with its size. See the >guest part: Where it matters, I do use it. Oh, I confused the guest/host part, but I could understand it. Thank you for your explanation. Best Regards, Akio Takebe ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/