From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DE7374758; Fri, 8 May 2026 16:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778258914; cv=none; b=oRUggo3FtCYp99B4l67nVfDyqgmbwf0LfBhWD/Q6wummu7C2Y0bxRl6RDBjQr3gJnYJhsMvxYQsO/hwR33dB6kuGsuY7moyyo8paOTdvDsVc24oHAKWYIy8KyfcuUT6EIOExcUQt+0lqfdF0hTYtIbcNTfXQ/JDeFFUBLaERvKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778258914; c=relaxed/simple; bh=pZPC+mlFC7zHFFRvjelepNFijit98+ahrAhP2MdO6h4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KA920Mjv4uiDtwCrUbKSHn2Hcaa1uPRFRUPWNukRJXu4ToIDDnfTFL6FXSPB+BMK11HEiAg3OG2NpEY6Vm6NAqTLD1KJKngKJoa+6gmrxK5ziyh6OPYpD+esHD9+WMf6FGwJriXah1hFiM9bNpgUf+nGU/tbAonOQ5QNmmOUd34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oJznOL2Q; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oJznOL2Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778258913; x=1809794913; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pZPC+mlFC7zHFFRvjelepNFijit98+ahrAhP2MdO6h4=; b=oJznOL2QT/R4EGbHVWpUxiVHE3M0U3Hpb7ld+O8RoXPEWKStX6SRUm0i P1U2R87OVqhh6ytcsHWQjZP9syf0OFn3QNxMg/Szt89+NmOIN23J7Yfzo 3zXRLqn45qtcMuWFwtiomt4qltXPalIpKSxm1GpF8B9iufGjeGW+cm3qA bHNF435YtuSdovZczJw+AnM9G/e4tQKsUkqR5PKDCoTClqcjqSCsdoFV2 cRJO199wa/9ed8U7uoiKQm2r9fxIoYkCSPjKUluDdKvkM68n90lbsQDyW tpCmI9rdxEqLb5mIjBiXhLpfzSeebj8OrO7GJWz9jZaAZWTyBXR00V/E3 Q==; X-CSE-ConnectionGUID: DctAqC39R8q36xPSCgFm2g== X-CSE-MsgGUID: LPlUxwGxQP6sfFoePsoWrg== X-IronPort-AV: E=McAfee;i="6800,10657,11780"; a="89934331" X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="89934331" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 09:48:32 -0700 X-CSE-ConnectionGUID: U7Bm0w8mSN6E+Mwqpx7Rsg== X-CSE-MsgGUID: ythbR+snRk+1ou5TooHTmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="237049767" Received: from dnelso2-mobl.amr.corp.intel.com (HELO [10.125.111.18]) ([10.125.111.18]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 09:48:32 -0700 Message-ID: <1bff2e14-e550-4e6f-a819-0e9a851413cc@intel.com> Date: Fri, 8 May 2026 09:48:37 -0700 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 08/21] x86/virt/seamldr: Allocate and populate a module update request To: Chao Gao Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org, binbin.wu@linux.intel.com, dave.hansen@linux.intel.com, djbw@kernel.org, ira.weiny@intel.com, kai.huang@intel.com, kas@kernel.org, nik.borisov@suse.com, paulmck@kernel.org, pbonzini@redhat.com, reinette.chatre@intel.com, rick.p.edgecombe@intel.com, sagis@google.com, seanjc@google.com, tony.lindgren@linux.intel.com, vannapurve@google.com, vishal.l.verma@intel.com, yilun.xu@linux.intel.com, xiaoyao.li@intel.com, yan.y.zhao@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <20260427152854.101171-1-chao.gao@intel.com> <20260427152854.101171-9-chao.gao@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/7/26 06:19, Chao Gao wrote: ... >>> + /* >>> + * Don't care about user passing the wrong file, but protect >>> + * kernel ABI by preventing accepting garbage. >>> + */ >>> + if (memcmp(blob->signature, "TDX-BLOB", 8)) >>> + return ERR_PTR(-EINVAL); >> >> Is there really no helper in the kernel anywhere that can safely do the >> 8-byte compare against two known-to-the-compiler 8-byte-wide fields >> without hard-coding the 8? > > I couldn't find a helper that automatically derives the comparison > length from the operands. 'strcmp()' is not suitable here because > 'blob->signature' is not NUL-terminated. > > Do you mean just avoiding the hard-coded 8, e.g. > > if (memcmp(blob->signature, "TDX-BLOB", sizeof(blob->signature))) > return ERR_PTR(-EINVAL); > > or define the 'u8 signature[8]' as a u64 and compare it with a constant, like > > /* Little-endian encoding of "TDX-BLOB" string */ > #define TDX_IMAGE_SIGNATURE 0x424f4c422d584454ULL > > if (blob->signature != TDX_IMAGE_SIGNATURE) > return ERR_PTR(-EINVAL); Either one of those is fine with me. I'd probably do the sizeof() variant, but no strong preference. >>> + struct seamldr_params *params; >>> + int module_pg_cnt, sig_pg_cnt; >>> + const u8 *sig, *module; >>> + int i; >>> + >>> + params = (struct seamldr_params *)get_zeroed_page(GFP_KERNEL); >>> + if (!params) >>> + return ERR_PTR(-ENOMEM); >> >> kzmalloc(PAGE_SIZE, GFP_KERNEL) will save you a cast. > > I noticed that 'kzalloc_obj()' can be used here, which avoids spelling out > the size and GFP flags explicitly. So I ended up with: > > params = kzalloc_obj(*params); That's fine too.