From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
To: liulongfang <liulongfang@huawei.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>
Subject: RE: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
Date: Tue, 12 Nov 2024 08:40:03 +0000 [thread overview]
Message-ID: <1c0a2990bc6243b281d53177bc30cc92@huawei.com> (raw)
In-Reply-To: <20241112073322.54550-4-liulongfang@huawei.com>
> -----Original Message-----
> From: liulongfang <liulongfang@huawei.com>
> Sent: Tuesday, November 12, 2024 7:33 AM
> To: alex.williamson@redhat.com; jgg@nvidia.com; Shameerali Kolothum
> Thodi <shameerali.kolothum.thodi@huawei.com>; Jonathan Cameron
> <jonathan.cameron@huawei.com>
> Cc: kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> linuxarm@openeuler.org; liulongfang <liulongfang@huawei.com>
> Subject: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon
> migration driver
>
>
> +static void hisi_acc_vfio_debug_init(struct hisi_acc_vf_core_device
> *hisi_acc_vdev)
> +{
> + struct vfio_device *vdev = &hisi_acc_vdev->core_device.vdev;
> + struct hisi_acc_vf_migration_file *migf = NULL;
> + struct dentry *vfio_dev_migration = NULL;
> + struct dentry *vfio_hisi_acc = NULL;
Nit, I think we can get rid of these NULL initializations.
If you have time, please consider respin (sorry, missed this in earlier reviews.)
Thanks,
Shameer
next prev parent reply other threads:[~2024-11-12 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 7:33 [PATCH v15 0/4] debugfs to hisilicon migration driver Longfang Liu
2024-11-12 7:33 ` [PATCH v15 1/4] hisi_acc_vfio_pci: extract public functions for container_of Longfang Liu
2024-11-12 7:33 ` [PATCH v15 2/4] hisi_acc_vfio_pci: create subfunction for data reading Longfang Liu
2024-11-12 7:33 ` [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver Longfang Liu
2024-11-12 8:40 ` Shameerali Kolothum Thodi [this message]
2024-11-12 21:50 ` Alex Williamson
2024-11-13 7:59 ` Shameerali Kolothum Thodi
2024-11-12 7:33 ` [PATCH v15 4/4] Documentation: add debugfs description for hisi migration Longfang Liu
2024-11-14 19:12 ` [PATCH v15 0/4] debugfs to hisilicon migration driver Alex Williamson
2024-11-15 8:36 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c0a2990bc6243b281d53177bc30cc92@huawei.com \
--to=shameerali.kolothum.thodi@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=liulongfang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox